-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ACR] Add ACR Build commands #6241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6241 |
|
The PR contains |
851ee94 to
011f3b8
Compare
|
@derekbekoe Yes we wanted to start the review process while working on publishing the new SDK Azure/azure-sdk-for-python#1935. I also owe tests for the new commands and will add them shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's $PAT?
Would suggest a different example value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with $PAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A FileCompleter may be useful here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much prefer using SDK values when possible.
Why this change? Does the SDK no longer document the skus available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use logger.warning for these user style messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with below on messages like 'Waiting for a build agent...' etc.
By using logger, the messages go to stderr instead of stdout.
|
@derekbekoe CI seems to be complaining the use of positional parameters. Could you please advise? We only have one such parameter. |
tjprescott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please show the -h output for the new commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a debug message and potentially unexpected behavior rather than a CLIError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a few cases that the response doesn't have the datetime yet. For example, if users trigger a build and immediately get the status of it before it finishes, we don't have a finish time here. This is table formatting path and we thought we can just show empty in the column rather than throwing an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here--if the user inputs an invalid format, then failing silently and having unexpected behavior is probably not better than throwing an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same reason as above handling response datetime. We don't format user inputs here. In this case, finish_time could be empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice this was for table format. Displaying blank is completely appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anywhere and everywhere "BOOL_CHOICES" is used, see:
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#registering-flags
|
@djyou reviewing the stack trace, it looks like certain stages of the CI load parameters twice, which is why your one positional argument is being found twice and throwing an error. I'll make a PR to fix this. |
05b8769 to
d58daaa
Compare
bb9f9d5 to
d26ab71
Compare
|
@derekbekoe I recommend we merge this. No idea what's going on with CI and it's recent constant timeouts on Integration. |
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.