Adding support for Private DNS Public Preview #5757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5757 |
Contributor
Author
|
Once the Python SDK is generated, I will update its version in this PR. |
tjprescott
suggested changes
Mar 8, 2018
Member
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
Overall looks great. Please just enhance your test to cover the new update functionality for registration/resolution vnets.
| 2.0.26 | ||
| ++++++ | ||
| * `network dns zone create`: Adding support for creating Private DNS zones. | ||
| * `network dns zone update`: Adding support for updating Private DNS zones. |
Member
There was a problem hiding this comment.
You can also just say network dns zone create/update.
| checks=self.is_empty()) | ||
|
|
||
| @ResourceGroupPreparer(name_prefix='cli_test_dns') | ||
| def test_private_dns(self, resource_group): |
Member
There was a problem hiding this comment.
Please add a couple lines to test the zone update convenience arguments.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating/updating Private DNS zones for the public preview release. It is based on the Python SDK PR Azure/azure-sdk-for-python#2096 which in turn is based on Swagger version 2018-03-01-preview Azure/azure-rest-api-specs#2587.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)