Skip to content

Advisor Module Updates #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 24 commits into from
Feb 27, 2018
Merged

Advisor Module Updates #5334

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7f18c4a
Updates for GA release.
Prasanna-Padmanabhan Jan 18, 2018
70e3f79
Merge remote-tracking branch 'upstream/dev' into dev
Prasanna-Padmanabhan Jan 18, 2018
77a0c2e
Addressing PR feedback:
Prasanna-Padmanabhan Jan 23, 2018
c6e7d08
Update history with details of the changes.
Prasanna-Padmanabhan Jan 24, 2018
ca47a9e
Adding generic update and show command.
Prasanna-Padmanabhan Feb 9, 2018
6c8c2ef
Addressing review feedback.
Prasanna-Padmanabhan Feb 13, 2018
d61ea43
Update SDK package version.
Prasanna-Padmanabhan Feb 13, 2018
bbe23bb
Merge remote-tracking branch 'upstream/dev' into dev
Prasanna-Padmanabhan Feb 13, 2018
64369a5
Addressing review feedback.
Prasanna-Padmanabhan Feb 16, 2018
6e17e92
Fix indentation errors.
Prasanna-Padmanabhan Feb 16, 2018
3b87d14
Merge pull request #2 from Azure/dev
Prasanna-Padmanabhan Feb 20, 2018
196c6b1
Merge pull request #3 from Azure/dev
Prasanna-Padmanabhan Feb 24, 2018
ae53cce
Add support for ids.
Prasanna-Padmanabhan Feb 24, 2018
05b6777
Updates for GA release.
Prasanna-Padmanabhan Jan 18, 2018
fa156b8
Addressing PR feedback:
Prasanna-Padmanabhan Jan 23, 2018
bd00ec3
Update history with details of the changes.
Prasanna-Padmanabhan Jan 24, 2018
19d3771
Adding generic update and show command.
Prasanna-Padmanabhan Feb 9, 2018
1e4e723
Addressing review feedback.
Prasanna-Padmanabhan Feb 13, 2018
5484ea9
Update SDK package version.
Prasanna-Padmanabhan Feb 13, 2018
917d3c7
Addressing review feedback.
Prasanna-Padmanabhan Feb 16, 2018
be1ab4a
Fix indentation errors.
Prasanna-Padmanabhan Feb 16, 2018
24cc6b9
Add support for ids.
Prasanna-Padmanabhan Feb 24, 2018
e653d72
Merge branch 'dev' of https://github.com/Prasanna-Padmanabhan/azure-c…
Prasanna-Padmanabhan Feb 26, 2018
710f4c4
Fix test failures.
Prasanna-Padmanabhan Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_modules/azure-cli-advisor/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

1.0.0

@tjprescott tjprescott Jan 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a GA release, it should be 2.0.0

++++++
* GA release.

@tjprescott tjprescott Jan 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you will want to call out whatever breaking changes were made. For example

* BC: `advisor configuration set` renamed to `advisor configuration update`

and so on.


0.1.1
++++++
* Update for CLI core changes.
Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-advisor/azure/cli/command_modules/advisor/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

helps['advisor'] = """
type: group
short-summary: (PREVIEW) Manage Azure Advisor.
short-summary: Manage Azure Advisor.
"""

helps['advisor configuration'] = """
Expand Down
18 changes: 9 additions & 9 deletions ...re/cli/command_modules/advisor/tests/recordings/latest/test_generate_recommendations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ interactions:
Connection: [keep-alive]
Content-Length: ['0']
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: POST
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Advisor/generateRecommendations?api-version=2017-04-19
Expand All @@ -18,14 +18,14 @@ interactions:
headers:
cache-control: [no-cache]
content-length: ['0']
date: ['Mon, 11 Dec 2017 22:58:43 GMT']
date: ['Thu, 18 Jan 2018 00:40:59 GMT']
expires: ['-1']
location: ['https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Advisor/generateRecommendations/0dba36fb-1faf-41f6-a711-37b7f57a29bd?api-version=2017-04-19']
location: ['https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Advisor/generateRecommendations/6180573c-fbd7-45b8-88ef-32c7a8789d43?api-version=2017-04-19']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
strict-transport-security: [max-age=31536000; includeSubDomains]
x-content-type-options: [nosniff]
x-ms-ratelimit-remaining-subscription-writes: ['1196']
x-ms-ratelimit-remaining-subscription-writes: ['1199']
status: {code: 202, message: Accepted}
- request:
body: null
Expand All @@ -35,16 +35,16 @@ interactions:
CommandName: [advisor recommendation generate]
Connection: [keep-alive]
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Advisor/generateRecommendations/0dba36fb-1faf-41f6-a711-37b7f57a29bd?api-version=2017-04-19
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Advisor/generateRecommendations/6180573c-fbd7-45b8-88ef-32c7a8789d43?api-version=2017-04-19
response:
body: {string: ''}
headers:
cache-control: [no-cache]
date: ['Mon, 11 Dec 2017 22:58:43 GMT']
date: ['Thu, 18 Jan 2018 00:40:59 GMT']
expires: ['-1']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
Expand Down
56 changes: 28 additions & 28 deletions ...d_modules/advisor/tests/recordings/latest/test_get_set_configurations_resource_group.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ interactions:
Connection: [keep-alive]
Content-Length: ['50']
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 resourcemanagementclient/1.2.1 Azure-SDK-For-Python
AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 resourcemanagementclient/1.2.1 Azure-SDK-For-Python
AZURECLI/2.0.26]
accept-language: [en-US]
method: PUT
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_advisor000001?api-version=2017-05-10
Expand All @@ -20,7 +20,7 @@ interactions:
cache-control: [no-cache]
content-length: ['328']
content-type: [application/json; charset=utf-8]
date: ['Mon, 11 Dec 2017 22:58:45 GMT']
date: ['Thu, 18 Jan 2018 00:41:01 GMT']
expires: ['-1']
pragma: [no-cache]
strict-transport-security: [max-age=31536000; includeSubDomains]
Expand All @@ -34,18 +34,18 @@ interactions:
CommandName: [advisor configuration get]
Connection: [keep-alive]
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations?api-version=2017-04-19
response:
body: {string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations/0b1f6471-1bf0-4dda-aec3-cb9272f09590-cli_test_advisor000001","type":"Microsoft.Advisor/Configurations","name":"0b1f6471-1bf0-4dda-aec3-cb9272f09590-cli_test_advisor000001","properties":{"exclude":false}}]}'}
body: {string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations/70b0b95c-8a41-41c0-8e3f-3ed8351a2d61-cli_test_advisor000001","type":"Microsoft.Advisor/Configurations","name":"70b0b95c-8a41-41c0-8e3f-3ed8351a2d61-cli_test_advisor000001","properties":{"exclude":false}}]}'}
headers:
cache-control: [no-cache]
content-length: ['514']
content-type: [application/json; charset=utf-8]
date: ['Mon, 11 Dec 2017 22:58:46 GMT']
date: ['Thu, 18 Jan 2018 00:41:02 GMT']
expires: ['-1']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
Expand All @@ -64,16 +64,16 @@ interactions:
Connection: [keep-alive]
Content-Length: ['33']
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: PUT
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations?api-version=2017-04-19
response:
body: {string: ''}
headers:
cache-control: [no-cache]
date: ['Mon, 11 Dec 2017 22:58:47 GMT']
date: ['Thu, 18 Jan 2018 00:41:03 GMT']
expires: ['-1']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
Expand All @@ -89,18 +89,18 @@ interactions:
CommandName: [advisor configuration get]
Connection: [keep-alive]
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations?api-version=2017-04-19
response:
body: {string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations/0b1f6471-1bf0-4dda-aec3-cb9272f09590-cli_test_advisor000001","type":"Microsoft.Advisor/Configurations","name":"0b1f6471-1bf0-4dda-aec3-cb9272f09590-cli_test_advisor000001","properties":{"exclude":true}}]}'}
body: {string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations/70b0b95c-8a41-41c0-8e3f-3ed8351a2d61-cli_test_advisor000001","type":"Microsoft.Advisor/Configurations","name":"70b0b95c-8a41-41c0-8e3f-3ed8351a2d61-cli_test_advisor000001","properties":{"exclude":true}}]}'}
headers:
cache-control: [no-cache]
content-length: ['513']
content-type: [application/json; charset=utf-8]
date: ['Mon, 11 Dec 2017 22:58:47 GMT']
date: ['Thu, 18 Jan 2018 00:41:04 GMT']
expires: ['-1']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
Expand All @@ -119,16 +119,16 @@ interactions:
Connection: [keep-alive]
Content-Length: ['34']
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: PUT
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations?api-version=2017-04-19
response:
body: {string: ''}
headers:
cache-control: [no-cache]
date: ['Mon, 11 Dec 2017 22:58:48 GMT']
date: ['Thu, 18 Jan 2018 00:41:05 GMT']
expires: ['-1']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
Expand All @@ -144,18 +144,18 @@ interactions:
CommandName: [advisor configuration get]
Connection: [keep-alive]
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 azure-mgmt-advisor/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 azure-mgmt-advisor/1.0.0 Azure-SDK-For-Python AZURECLI/2.0.26]
accept-language: [en-US]
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations?api-version=2017-04-19
response:
body: {string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations/0b1f6471-1bf0-4dda-aec3-cb9272f09590-cli_test_advisor000001","type":"Microsoft.Advisor/Configurations","name":"0b1f6471-1bf0-4dda-aec3-cb9272f09590-cli_test_advisor000001","properties":{"exclude":false}}]}'}
body: {string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_advisor000001/providers/Microsoft.Advisor/configurations/70b0b95c-8a41-41c0-8e3f-3ed8351a2d61-cli_test_advisor000001","type":"Microsoft.Advisor/Configurations","name":"70b0b95c-8a41-41c0-8e3f-3ed8351a2d61-cli_test_advisor000001","properties":{"exclude":false}}]}'}
headers:
cache-control: [no-cache]
content-length: ['514']
content-type: [application/json; charset=utf-8]
date: ['Mon, 11 Dec 2017 22:58:49 GMT']
date: ['Thu, 18 Jan 2018 00:41:07 GMT']
expires: ['-1']
pragma: [no-cache]
server: [Microsoft-HTTPAPI/2.0]
Expand All @@ -174,9 +174,9 @@ interactions:
Connection: [keep-alive]
Content-Length: ['0']
Content-Type: [application/json; charset=utf-8]
User-Agent: [python/3.6.2 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.19
msrest_azure/0.4.18 resourcemanagementclient/1.2.1 Azure-SDK-For-Python
AZURECLI/2.0.22]
User-Agent: [python/3.6.3 (Windows-10-10.0.16299-SP0) requests/2.18.4 msrest/0.4.18
msrest_azure/0.4.15 resourcemanagementclient/1.2.1 Azure-SDK-For-Python
AZURECLI/2.0.26]
accept-language: [en-US]
method: DELETE
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_advisor000001?api-version=2017-05-10
Expand All @@ -185,11 +185,11 @@ interactions:
headers:
cache-control: [no-cache]
content-length: ['0']
date: ['Mon, 11 Dec 2017 22:58:50 GMT']
date: ['Thu, 18 Jan 2018 00:41:08 GMT']
expires: ['-1']
location: ['https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/operationresults/eyJqb2JJZCI6IlJFU09VUkNFR1JPVVBERUxFVElPTkpPQi1DTEk6NUZURVNUOjVGQURWSVNPUkRRUlczT1FSM0RYVVRUQU9JWDQ3R0pNU1k3V3wxOEMxRjE5RjRFRDcyQTdDLVdFU1RVUyIsImpvYkxvY2F0aW9uIjoid2VzdHVzIn0?api-version=2017-05-10']
location: ['https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/operationresults/eyJqb2JJZCI6IlJFU09VUkNFR1JPVVBERUxFVElPTkpPQi1DTEk6NUZURVNUOjVGQURWSVNPUkVQQzVXNVlaUUU3U1hPUDI1N05KVFNFV1FKS3xDNzBFNzZERDJBNjBEMkZFLVdFU1RVUyIsImpvYkxvY2F0aW9uIjoid2VzdHVzIn0?api-version=2017-05-10']
pragma: [no-cache]
strict-transport-security: [max-age=31536000; includeSubDomains]
x-ms-ratelimit-remaining-subscription-writes: ['1199']
x-ms-ratelimit-remaining-subscription-writes: ['1198']
status: {code: 202, message: Accepted}
version: 1
Loading