Skip to content

[Network/Storage] Rename private access vnet and add network rule storage commands#4269

Merged
tjprescott merged 11 commits intoAzure:masterfrom
tjprescott:RenamePrivateAccessVnet
Aug 24, 2017
Merged

[Network/Storage] Rename private access vnet and add network rule storage commands#4269
tjprescott merged 11 commits intoAzure:masterfrom
tjprescott:RenamePrivateAccessVnet

Conversation

@tjprescott
Copy link
Copy Markdown
Member

Closes #4067.

This PR renames the "private access" features introduced in a recent release to "service endpoints". This is a breaking change.

Additionally, this PR adds storage account commands to manage network rules, used in conjunction with the service endpoint feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@tjprescott tjprescott added Breaking Change do-not-merge Network az network vnet/lb/nic/dns/etc... Storage az storage labels Aug 18, 2017
@tjprescott tjprescott added this to the Sprint 21 milestone Aug 18, 2017
@tjprescott tjprescott requested a review from troydai August 18, 2017 21:15
@tjprescott
Copy link
Copy Markdown
Member Author

This PR is being opened now for review. It will not pass CI and thus cannot be merged. The work was done based on a draft azure-mgmt-network Python SDK that hasn't been published yet. Additionally, should Azure/azure-rest-api-specs#1494 be merged soon, I will need a new azure-mgmt-storage SDK published.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4269 into master will increase coverage by 0.02%.
The diff coverage is 83.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4269      +/-   ##
==========================================
+ Coverage   70.12%   70.15%   +0.02%     
==========================================
  Files         475      475              
  Lines       29692    29769      +77     
  Branches     4556     4575      +19     
==========================================
+ Hits        20822    20883      +61     
- Misses       7426     7434       +8     
- Partials     1444     1452       +8
Impacted Files Coverage Δ
.../azure-cli-core/azure/cli/core/profiles/_shared.py 88.18% <ø> (ø) ⬆️
src/azure-cli-core/azure/cli/core/commands/arm.py 83.3% <0%> (-0.31%) ⬇️
...twork/azure/cli/command_modules/network/_params.py 93.42% <100%> (ø) ⬆️
...work/azure/cli/command_modules/network/commands.py 94.35% <100%> (ø) ⬆️
...ure/cli/command_modules/network/_client_factory.py 84.61% <100%> (+1.28%) ⬆️
...orage/azure/cli/command_modules/storage/_params.py 87.08% <100%> (+0.24%) ⬆️
...network/azure/cli/command_modules/network/_help.py 100% <100%> (ø) ⬆️
...storage/azure/cli/command_modules/storage/_help.py 100% <100%> (ø) ⬆️
...etwork/azure/cli/command_modules/network/custom.py 62.46% <100%> (+0.32%) ⬆️
...rage/azure/cli/command_modules/storage/commands.py 97.07% <75%> (-1.12%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a936d...6a3531e. Read the comment docs.

@tjprescott tjprescott merged commit 294f16a into Azure:master Aug 24, 2017
@tjprescott tjprescott deleted the RenamePrivateAccessVnet branch August 24, 2017 15:43
@haroldrandom haroldrandom added Breaking Change cla-not-required Network az network vnet/lb/nic/dns/etc... Storage az storage labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change cla-not-required Network az network vnet/lb/nic/dns/etc... Storage az storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants