[Network/Storage] Rename private access vnet and add network rule storage commands#4269
Merged
tjprescott merged 11 commits intoAzure:masterfrom Aug 24, 2017
tjprescott:RenamePrivateAccessVnet
Merged
[Network/Storage] Rename private access vnet and add network rule storage commands#4269tjprescott merged 11 commits intoAzure:masterfrom tjprescott:RenamePrivateAccessVnet
tjprescott merged 11 commits intoAzure:masterfrom
tjprescott:RenamePrivateAccessVnet
Conversation
Member
Author
|
This PR is being opened now for review. It will not pass CI and thus cannot be merged. The work was done based on a draft |
troydai
approved these changes
Aug 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #4269 +/- ##
==========================================
+ Coverage 70.12% 70.15% +0.02%
==========================================
Files 475 475
Lines 29692 29769 +77
Branches 4556 4575 +19
==========================================
+ Hits 20822 20883 +61
- Misses 7426 7434 +8
- Partials 1444 1452 +8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4067.
This PR renames the "private access" features introduced in a recent release to "service endpoints". This is a breaking change.
Additionally, this PR adds storage account commands to manage network rules, used in conjunction with the service endpoint feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)