Conversation
…d to default to None
️✔️AzureCLI-FullTest
|
|
Hi @mattboentoro, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
mattboentoro
changed the title
az postgres flexible-server create: Change database name field to default to None
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the az postgres flexible-server create command where the database_name parameter was referencing an undefined argument type database_name_create_arg_type, which would cause a runtime error.
- Corrects the
database_nameparameter to use the existingdatabase_name_arg_type - Explicitly sets
default=Nonefor clarity, as the parameter is optional
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@evelyn-ys do you mind reviewing this PR? |
|
Please define and put back for create “database_name_create_arg_type” to use of db renaming for clusters. This will be different than normal db name property used in db commands. Hav description state use for clusters. |
|
[RDBMS] az postgres flexible-server create: Change database name field to default to None -> {RDBMS} az postgres flexible-server create: BUG FIX Define database name argument Not public facing change |
|
Please fix CI issues |
|
@yonzhan do you mind reviewing this PR? |
5 participants
Related command
az postgres flexible-server create
Description
Change database name field to default to None
Testing Guide
Manual testing
History Notes
[RDBMS]
az postgres flexible-server create: Change database name field to default to NoneThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.