-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Role} az role: Bump azure-mgmt-authorization to single-API SDK
#31859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
️✔️AzureCLI-BreakingChangeTest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the azure-mgmt-authorization package from version 4.0.0 to 5.0.0 to adopt a single-API SDK approach, eliminating the need for explicit API version management in the CLI codebase.
- Updates package version across all platform-specific requirements files
- Removes explicit API version constraints from role assignment commands and parameters
- Simplifies the authorization resource type profile configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.py3.windows.txt | Updates azure-mgmt-authorization from 4.0.0 to 5.0.0 |
| requirements.py3.Linux.txt | Updates azure-mgmt-authorization from 4.0.0 to 5.0.0 |
| requirements.py3.Darwin.txt | Updates azure-mgmt-authorization from 4.0.0 to 5.0.0 |
| commands.py | Removes min_api constraint from update_role_assignment command |
| _params.py | Removes min_api constraints from role assignment parameters |
| _shared.py | Simplifies MGMT_AUTHORIZATION profile from SDKProfile to None |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
eeafcf8 to
f5288e5
Compare
| - AZURECLI/2.65.0 azsdk-python-core/1.31.0 Python/3.11.9 (macOS-14.7-x86_64-i386-64bit) | ||
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_aro000001/providers/Microsoft.Network/virtualNetworks/dev-vnet/providers/Microsoft.Authorization/permissions?api-version=2015-07-01 | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_aro000001/providers/Microsoft.Network/virtualNetworks/dev-vnet/providers/Microsoft.Authorization/permissions?api-version=2022-05-01-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live run this test azdev test --series --live test_aro_public_cluster fails:
aad = AADManager(cmd.cli_ctx)
rp_client_sp_id = aad.get_service_principal_id(resolve_rp_client_id())
if not rp_client_sp_id:
> raise ResourceNotFoundError("RP service principal not found.")
E azure.cli.core.azclierror.ResourceNotFoundError: RP service principal not found.
src\azure-cli\azure\cli\command_modules\aro\custom.py:229: ResourceNotFoundError
ec9036d to
9c2341c
Compare
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for acs (AKS)
az role: Bump azure-mgmt-authorization to single-API SDK az role: Bump azure-mgmt-authorization to single-API SDK
Related command
az roleDescription
Similar to #31526, #31801, this PR bumps
azure-mgmt-authorizationto single-API SDK.A private package generated from package-2024-09-01-preview has been tested. It contains all necessary API versions CLI declares:
azure-cli/src/azure-cli-core/azure/cli/core/profiles/_shared.py
Lines 195 to 197 in a7e596e
Luckily, no API version bump is introduced, so there is no need to record tests again.