[AKS] az aks: Add --node-provisioning-mode and --node-provisioning-default-pools parameters
#31836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter node_provisioning_default_pools |
||
| aks create | cmd aks create added parameter node_provisioning_mode |
||
| aks update | cmd aks update added parameter node_provisioning_default_pools |
||
| aks update | cmd aks update added parameter node_provisioning_mode |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the --node-provisioning-mode and --node-provisioning-default-pools parameters to the AKS CLI, enabling the new node auto-provisioning feature. The changes include parameter definitions, decorator functions for setting up and updating node provisioning profiles, and comprehensive test coverage.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
custom.py |
Added parameter definitions for node provisioning mode and default pools |
managed_cluster_decorator.py |
Implemented core functionality for setting up and updating node provisioning profiles |
test_managed_cluster_decorator.py |
Added unit tests for node provisioning profile setup and update functions |
test_aks_commands.py |
Added integration tests for create/update commands with node provisioning parameters |
test_aks_create_node_provisioning_profile.yaml |
Test recording file for node provisioning profile creation |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py:10845
- Remove the stray '-' character on line 12952. This appears to be a formatting artifact that should be cleaned up.
# find the latest non-LTS version in the
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Auto-Assign
matthchr
force-pushed
the
matthchr/nap-ga
branch
2 times, most recently
from
57fbd39 to
28eb0ce
Compare
tallaxes
reviewed
Jul 17, 2025
tallaxes
approved these changes
Jul 17, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Jul 18, 2025
Member
There was a problem hiding this comment.
lgtm, queued live test to validate the change, test passed!
- test_aks_create_node_provisioning_profile
- test_aks_update_node_provisioning_profile
matthchr
changed the title
az aks: Add --node-provisioning-mode and --node-provisioning-default-pools parametersaz aks: Add --node-provisioning-mode and --node-provisioning-default-pools parameters
matthchr
force-pushed
the
matthchr/nap-ga
branch
2 times, most recently
from
d1b53ac to
50983db
Compare
Member
Author
|
I fixed the test/lint issues:
|
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31836 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
previously approved these changes
Jul 21, 2025
Contributor
|
please resolve the code conflicts. |
--node-provisioning-mode and --node-provisioning-default-pools
matthchr
force-pushed
the
matthchr/nap-ga
branch
from
50983db to
e7d4658
Compare
Member
Author
|
Conflicts resolved and I rebased. Please merge when you can to avoid additional conflicts |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Jul 23, 2025
zhoxing-ms
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aksDescription
Add two new options to the AKS CLI --node-provisioning-mode and --node-provisioning-default-pools.
These options are related to the node auto-provisioning (aka.ms/nap) feature GA.
Testing Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.