{Packaging} Bump semver to 3.0.4
#31523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
bebound,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the semver dependency across the project to move from version 2.13.0 to 3.0.4, removing the strict pin in setup.py and pinning 3.0.4 in all platform-specific requirement files.
- Removed exact
semver==2.13.0pin insetup.py - Updated
requirements.py3.*.txton Windows, Linux, and Darwin tosemver==3.0.4
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/setup.py | Removed strict semver version pin |
| src/azure-cli/requirements.py3.windows.txt | Bumped semver pin to 3.0.4 |
| src/azure-cli/requirements.py3.Linux.txt | Bumped semver pin to 3.0.4 |
| src/azure-cli/requirements.py3.Darwin.txt | Bumped semver pin to 3.0.4 |
Comments suppressed due to low confidence (1)
src/azure-cli/requirements.py3.windows.txt:127
- [nitpick] Given the major-version bump of semver, add or update tests that exercise any semver-based logic to verify compatibility with version 3.0.4.
semver==3.0.4
src/azure-cli/setup.py
Outdated
| 'PyNaCl~=1.5.0', | ||
| 'scp~=0.13.2', | ||
| 'semver==2.13.0', | ||
| 'semver', |
There was a problem hiding this comment.
Specify a version constraint for semver in setup.py (e.g., 'semver>=3.0.4,<4.0') to avoid pulling in unintended future major or breaking releases.
Suggested change
| 'semver', | |
| 'semver>=3.0.0,<4.0.0', |
wangzelin007
approved these changes
May 22, 2025
evelyn-ys
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #31519
semverwas pinned to2.13.0by #16857.2.13.0was released 5 years ago.