Skip to content

{Profile} az login: Add check for --username for managed identity authentication #31453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
May 12, 2025
Merged

{Profile} az login: Add check for --username for managed identity authentication #31453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/azure-cli/azure/cli/command_modules/profile/_breaking_change.py
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions src/azure-cli/azure/cli/command_modules/profile/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ def login(cmd, username=None, password=None, tenant=None, scopes=None, allow_no_
# quick argument usage check
if any([password, service_principal, tenant]) and identity:
raise CLIError("usage error: '--identity' is not applicable with other arguments")
if identity and username:
raise CLIError('Passing the managed identity ID with --username is no longer supported. '
'Use --client-id, --object-id or --resource-id instead.')
if any([password, service_principal, username, identity]) and use_device_code:
raise CLIError("usage error: '--use-device-code' is not applicable with other arguments")
if use_cert_sn_issuer and not service_principal:
Expand All @@ -152,9 +155,6 @@ def login(cmd, username=None, password=None, tenant=None, scopes=None, allow_no_
if identity:
if in_cloud_console():
return profile.login_in_cloud_shell()
if username:
from azure.cli.core.breaking_change import print_conditional_breaking_change
print_conditional_breaking_change(cmd.cli_ctx, tag='ManagedIdentityUsernameBreakingChange')
return profile.login_with_managed_identity(
client_id=client_id, object_id=object_id, resource_id=resource_id,
allow_no_subscriptions=allow_no_subscriptions)
Expand Down