{Auth} Clarify Identity class's boundary
#31014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
evelyn-ys
approved these changes
Mar 17, 2025
evelyn-ys
reviewed
Mar 17, 2025
Comment on lines
-205
to
-206
| def login_in_cloud_shell(self, scopes): | ||
| raise NotImplementedError |
Member
There was a problem hiding this comment.
Why do we need to remove login_in_cloud_shell Since cloud_shell is a special user identity in msal?
Member
Author
There was a problem hiding this comment.
I don't agree with MSAL's design, see #29637 (comment), #29637 (comment) for detailed explanations.
I want to keep the calling pattern for Identity consistent - authority should always be a required parameter.
For Cloud Shell authentication, the CLI command is az login --identity. It is a managed identity credential, no matter what token is returned. Including CloudShellCredential in Identity blurs its boundary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
Part of #25959
Identitywill never be used for managed identity authentication, as managed identity inherently differs from user or service principal:authority. Also, because the network request is expensive, a local token cache is used.authorityis required. As IMDS has its own token cache, a local token cache is not necessary.Of course, it is possible to make
authorityoptional andIdentitywork for managed identity, but this requires more effort and blursIdentity's boundary. According to https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow, the public-facing name of eSTS is "Microsoft identity platform", so calling this classIdentityand limit it to user or service principal authentication is accurate and reasonable.This PR clarifies
Identityclass's boundary and deletes unused methods.