Skip to content

[App Config] az appconfig: Fix MSI auth for --auth-mode login parameter #30983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 6 commits into from
Mar 23, 2025
Merged

[App Config] az appconfig: Fix MSI auth for --auth-mode login parameter #30983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4386ac
Fix MSI auth.
albertofori Mar 7, 2025
a938151
Adding tests.
albertofori Mar 19, 2025
4343c16
Merge branch 'dev' of https://github.com/Azure/azure-cli into msiFix
albertofori Mar 19, 2025
5df8d66
Updating tests.
albertofori Mar 20, 2025
a399208
Updating tests and removing unneded comment.
albertofori Mar 20, 2025
aea723e
Updating test
albertofori Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/appconfig/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def get_appconfig_data_client(cmd, name, connection_string, auth_mode, endpoint)
token_audience = current_cloud.endpoints.appconfig_auth_token_audience

try:
azconfig_client = AzureAppConfigurationClient(credential=AppConfigurationCliCredential(cred._credential, token_audience), # pylint: disable=protected-access
azconfig_client = AzureAppConfigurationClient(credential=AppConfigurationCliCredential(cred, token_audience),
base_url=endpoint,
user_agent=HttpHeaders.USER_AGENT)
except (ValueError, TypeError) as ex:
Expand Down
12,241 changes: 6,804 additions & 5,437 deletions ..._modules/appconfig/tests/latest/recordings/test_appconfig_to_appconfig_import_export.yaml
View file
Open in desktop

Large diffs are not rendered by default.

11,223 changes: 6,278 additions & 4,945 deletions ...i/azure/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_aad_auth.yaml
View file
Open in desktop

Large diffs are not rendered by default.

9,750 changes: 5,548 additions & 4,202 deletions ...azure/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_credential.yaml
View file
Open in desktop

Large diffs are not rendered by default.

112,299 changes: 64,016 additions & 48,283 deletions ...li/azure/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_feature.yaml
View file
Open in desktop

Large diffs are not rendered by default.

87,466 changes: 49,931 additions & 37,535 deletions ...e/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_feature_filter.yaml
View file
Open in desktop

Large diffs are not rendered by default.

19,682 changes: 11,258 additions & 8,424 deletions .../command_modules/appconfig/tests/latest/recordings/test_azconfig_feature_namespacing.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading