[App Config] az appconfig: Add support for custom token audience to --auth-mode login parameter
#30739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertofori
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
avanigupta and
yonzhan
microsoft-github-policy-service
bot
added
App Configuration
Auto-Assign
avanigupta
approved these changes
Jan 30, 2025
Member
Author
|
@zhoxing-ms , @yanzhudd , could you please help take a look at, and merge this PR? |
Contributor
|
please resolve the code conflicts. |
Contributor
|
please note that Azure CLI will freeze the code on 02/25/2025 10:00 UTC for the upcoming release. If you want to catch this release train, please resolve the comments ASAP, otherwise this PR has to be postponed to next sprint. |
Contributor
|
May I ask if this change is perceptible to users or not? If so, please use |
albertofori
changed the title
az appconfig ... --auth-mode login: Add support for custom token audienceaz appconfig ... --auth-mode login: Add support for custom token audience
Member
Author
@yanzhudd, please the conflicts have been resolved and this should be ready for merge. Could you help merge this in? |
yanzhudd
changed the title
az appconfig ... --auth-mode login: Add support for custom token audienceaz appconfig --auth-mode login: Add support for custom token audience
yanzhudd
changed the title
az appconfig --auth-mode login: Add support for custom token audienceaz appconfig --auth-mode login: Add support for custom token audience
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az appconfig --auth-mode login: Add support for custom token audienceaz appconfig: Add support for custom token audience to --auth-mode login parameter
yanzhudd
approved these changes
Feb 25, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
… `--auth-mode login` parameter (Azure#30739)
jiasli
reviewed
Mar 24, 2025
|
|
||
| try: | ||
| azconfig_client = AzureAppConfigurationClient(credential=cred, | ||
| azconfig_client = AzureAppConfigurationClient(credential=AppConfigurationCliCredential(cred._credential, token_audience), # pylint: disable=protected-access |
Member
There was a problem hiding this comment.
Accessing protected attribute _credential is wrong. The pylint error protected-access should not be disabled.
This has been reverted by #30983.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az appconfigDescription
When using the login auth method, this change ensures an optional token audience in the cloud config is respected if specified.
Testing Guide
History Notes
[App Config]
az appconfig: Add support for custom token audience to--auth-mode loginparameterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.