[Network] az network private-dns link vnet: Support resolution policy for virtual network link
#30115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network private-dns link vnet create | cmd network private-dns link vnet create added parameter resolution_policy |
||
| network private-dns link vnet update | cmd network private-dns link vnet update added parameter resolution_policy |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
pranavpnair
changed the title
pranavpnair
changed the title
pranavpnair
changed the title
pranavpnair
requested review from
jsntcy,
kairu-ms and
necusjz
as code owners
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 30115 in repo Azure/azure-cli |
Contributor
Author
|
Pushed a commit to re-record broken tests in mysql and postgres that were using privatedns resources. @necusjz Can you please help with restarting the Azure pipeline executions again? Seems I do not have sufficient privileges when I tried to use /azp run |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
approved these changes
Oct 21, 2024
necusjz
changed the title
az network private-dns link vnet: Support resolution policy for virtual network link
evelyn-ys
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
network private-dns link vnet create
network private-dns link vnet delete
network private-dns link vnet list
network private-dns link vnet show
network private-dns link vnet update
network private-dns link vnet wait
Description
In this change, we add a new property to (private dns) vnet link resources: resolutionPolicy. This will be an optional parameter in CLI. It is an enum that consists of two possible values - "Default" or "NxDomainRedirect".
For example, to create a new vnet link with resolutionPolicy property set to "NxDomainRedirect", one can run the following command:
az network private-dns link vnet create -g myResourceGroup -n myLink -z privatelink.consoto.com -v {vnet-resourceId} -e True/False --resolution-policy NxDomainRedirectThis property has already been added to swagger and other language SDKs and publicly released.
Swagger change: Azure/azure-rest-api-specs#29470
New property can be found here
.NET sdk reference documentation can be found here
Pull request on Aaz repo: Azure/aaz#591
Testing Guide
Added new tests and generated yaml files.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.