{Misc.} Improve code style and prepare for pylint 3 #29373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Misc. |
yonzhan
previously approved these changes
Jul 12, 2024
bebound
commented
Jul 16, 2024
| def __iter__(self): | ||
| for key in self._data: | ||
| yield key | ||
| yield from self._data |
Contributor
Author
There was a problem hiding this comment.
src/azure-cli-core/azure/cli/core/aaz/_field_value.py:185:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)
bebound
commented
Jul 16, 2024
| for idx in self._data: | ||
| if idx + 1 > self._len: | ||
| self._len = idx + 1 | ||
| self._len = max(self._len, idx + 1) |
Contributor
Author
There was a problem hiding this comment.
src/azure-cli-core/azure/cli/core/aaz/_field_value.py:329:16: R1731: Consider using '_len = max(_len, idx + 1)' instead of unnecessary if block (consider-using-max-builtin)
bebound
commented
Jul 16, 2024
| partition_count = int(partition_count) | ||
| if replica_count > 0: | ||
| if replica_count > 0: # pylint: disable=consider-using-min-builtin | ||
| instance.replica_count = replica_count |
Contributor
Author
There was a problem hiding this comment.
consider-using-min-builtin should not be raised.
See pylint-dev/pylint#9800
Contributor
|
pylint-dev/pylint#9800 was fixed and the fix will be available in next release. |
Contributor
Author
Thanks for the quick fix. Do you have a schedule for the next release? |
Contributor
|
No I don't, but it seems reasonable to say that it will be released shortly, seeing that the milestone has no open issues left and releases are done in 2-3 weeks and the last release was 3 weeks ago. |
bebound
commented
Jul 23, 2024
| implicit-str-concat, | ||
| unnecessary-dunder-call, | ||
| # These rules were added in Pylint >= 3.2 | ||
| possibly-used-before-assignment, |
Contributor
Author
There was a problem hiding this comment.
This rule is hard to fix and make the code hard to read.
bebound
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
jiasli
approved these changes
Jul 25, 2024
zhoxing-ms
approved these changes
Jul 25, 2024
Contributor
|
@kamperiadis Please help review the App Service related code |
Contributor
|
@zubairabid Please help review the Backup related code |
kairu-ms
approved these changes
Jul 25, 2024
zubairabid
approved these changes
Jul 25, 2024
Contributor
zubairabid
left a comment
zubairabid
left a comment
There was a problem hiding this comment.
Changes in backup code look good to me.
necusjz
approved these changes
Jul 25, 2024
yanzhudd
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for Azure/azure-cli-dev-tools#458