[Packaging] Drop Ubuntu 18.04 support #28942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Drop Ubuntu 18.04 support |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
jiasli
reviewed
May 13, 2024
Comment on lines
-26
to
-33
| # In Ubuntu 18.04, debhelper 11.1.6 has bug which makes it fail to dpkg-buildpackage. Use backport version instead. | ||
| # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897569 | ||
| if cat /etc/lsb-release | grep 18.04 | ||
| then | ||
| apt-get install -y debhelper -t bionic-backports | ||
| else | ||
| apt-get install -y debhelper | ||
| fi |
Member
There was a problem hiding this comment.
This workaround was added in #24180. We also had a discussion at #24180 (comment). Glad we are finally getting rid of it.
jiasli
reviewed
May 13, 2024
Comment on lines
-955
to
-960
| Bionic ${{ arch.name }}: | ||
| # 18.04 | ||
| deb_system: ubuntu | ||
| distro: bionic | ||
| arch: ${{ arch.value }} | ||
| pool: ${{ arch.pool }} |
Member
There was a problem hiding this comment.
I am surprised that the TestDebPackages job for Bionic has been dropped as early as #15833.
jiasli
approved these changes
May 13, 2024
Member
|
Shall we merge this PR in the next sprint so that we can release for Ubuntu 18.04 one last time? |
Contributor
Author
|
Since next sprint is a breaking change windows, let's drop it in this sprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 18.04 reached its EOL in June 2023.
Drop it to reduce the maintenance efforts as we support 24.04 now.
Ref: https://wiki.ubuntu.com/Releases