[Storage] az storage file copy start: Fix when copying between two storage accounts and source file has no parent directory
#28123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinhzy
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Storage |
…when copy from source root directory
calvinhzy
changed the title
az storage file copy start: Fix when source file has no parent directoryaz storage file copy start: Fix when copying between two storage accounts and source file has no parent directory
Member
|
It's better to enrich the PR description to explain what's before and after the fix |
evelyn-ys
approved these changes
Jan 18, 2024
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…storage accounts and source file has no parent directory (Azure#28123) * fix `az storage file copy start` with source file with no parent directory * add tests for copy file between different storage accounts, and case when copy from source root directory * remove sas token for credscan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
When copying between different storage accounts and the source file has no parent directory, the directory is parsed to be an empty string instead of None. This results in a sas token with an incorrect signature. Changes the directory to None fixes this.
Testing Guide
History Notes
[Storage]
az storage file copy start: Fix when copying between two storage accounts and source file has no parent directoryThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.