[AD] az ad: Rename Azure Active Directory to Microsoft Entra ID
#27756
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
|
AAD rebranding to Microsoft Entra ID |
microsoft-github-policy-service
bot
requested review from
calvinhzy and
wangzelin007
There was a problem hiding this comment.
All application permissions are high-privileged and requires admin consent.
Also, the permission name is quite self-explanatory. There is no need to copy and paste its definition from MS Graph doc.
There was a problem hiding this comment.
It is pretty obvious the group is created in the directory. If we mention in the director here, it should also be mentioned for app, sp and user.
There was a problem hiding this comment.
I moved these help messages from src/azure-cli/azure/cli/command_modules/role/custom.py to src/azure-cli/azure/cli/command_modules/role/_help.py so that they can align with the rest of az ad command group. This also allows us to add examples in the future. (docstring in custom.py doesn't support examples.)
There was a problem hiding this comment.
This help message is updated according to https://learn.microsoft.com/en-us/graph/api/resources/user?view=graph-rest-1.0#properties
|
According to what we agreed in today's meeting, I have updated the description of
Individual commands such as |
yonzhan
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
| For details on Microsoft Graph permissions, see https://learn.microsoft.com/graph/permissions-reference | ||
| examples: | ||
| - name: Add Microsoft Graph delegated permission User.Read (Sign in and read user profile). | ||
| - name: Add Microsoft Graph delegated permission User.Read |
There was a problem hiding this comment.
I deliberately didn't add period (.) to this sentence as it can confuse the user to perceive the permission name as User.Read..
dbradish-microsoft
left a comment
dbradish-microsoft
left a comment
There was a problem hiding this comment.
My suggested updates are optional.
| help="Application developers can configure optional claims in their Azure AD applications to " | ||
| help="Application developers can configure optional claims in their Microsoft Entra applications to " | ||
| "specify the claims that are sent to their application by the Microsoft security token " | ||
| "service. For more information, see https://docs.microsoft.com/azure/active-directory/develop" |
There was a problem hiding this comment.
| "service. For more information, see https://docs.microsoft.com/azure/active-directory/develop" | |
| "service. For more information, see https://learn.microsoft.com/entra/identity-platform/" |
There was a problem hiding this comment.
The description is copied from https://learn.microsoft.com/en-us/graph/api/resources/application?view=graph-rest-1.0. I prefer not to change it until the source is changed.
7 participants
Related command
az adDescription
This PR renames Azure Active Directory to Microsoft Entra ID following rules defined in
The help messages for
app,sp,userandgroupare very inconsistent:app: Manage applications with AAD Graph.sp: Manage Azure Active Directory service principals for automation authentication.user: Manage Azure Active Directory users and user authentication.group: Manage Azure Active Directory groups.This PR unifies those help messages to a format of
Manage Microsoft Entra xxx.I don't feel the necessity of prefixing the entities withMicrosoft Entraas they are already under theaz adcommand group.Azure PowerShell cmdlets
New-AzADxxxdon't mention Azure Active Directory in their help messages either: https://learn.microsoft.com/en-us/powershell/module/az.resources/. For example, the help message ofNew-AzADApplicationisAdds new entity to applications.