[App Service] az functionapp create: Add workload profile support for Centauri apps
#27736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khkh-ms
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @khkh-ms, |
|
Hi @khkh-ms, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| functionapp config container set | cmd functionapp config container set added parameter cpu |
||
| functionapp config container set | cmd functionapp config container set added parameter memory |
||
| functionapp config container set | cmd functionapp config container set added parameter workload_profile_name |
||
| functionapp create | cmd functionapp create added parameter cpu |
||
| functionapp create | cmd functionapp create added parameter memory |
||
| functionapp create | cmd functionapp create added parameter workload_profile_name |
microsoft-github-policy-service
bot
requested review from
ruslany and
sanchitmehta
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
pagariyaalok,
torosent,
vinisoto and
vturecek
Contributor
|
please resolve CI issues and conflicts |
# Conflicts: # src/azure-cli/azure/cli/command_modules/appservice/_params.py # src/azure-cli/azure/cli/command_modules/appservice/custom.py
kamperiadis
suggested changes
Dec 15, 2023
Comment on lines
1786
to
1788
| _validate_cpu_momory_functionapp(cpu, memory) | ||
| update_resource_config(cmd, resource_group_name, name, cpu=cpu, memory=memory, | ||
| workload_profile_name=workload_profile_name) |
Contributor
There was a problem hiding this comment.
Can you add a check here to make sure that the updates are only made if workload_profile_name, cpu or memory are updated?
| raise CLIError(ex) | ||
|
|
||
|
|
||
| def update_resource_config(cmd, resource_group_name, name, workload_profile_name=None, cpu=None, memory=None): |
Contributor
There was a problem hiding this comment.
Also, might be a good idea to rename this function since it is not clear just from the name what exactly would be updated. I would update it to something like update_workload_profile_config
# Conflicts: # src/azure-cli/azure/cli/command_modules/appservice/custom.py
yanzhudd
previously approved these changes
Dec 19, 2023
kamperiadis
previously approved these changes
Dec 19, 2023
…ted, update indexing
kamperiadis
approved these changes
Dec 19, 2023
wangzelin007
approved these changes
Dec 20, 2023
Member
|
LGTM |
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…or Centauri apps (Azure#27736) * workload changes * small fix * Added tests. * Addressing the comments. * Updates after changes. * Updated messages * test update. * updated unit tests * Removed the test SDK version * One more change * Few more changes in test. * pylint fixes. * Changes after merge. * Changed regions in the tests. * cred-tests * typo * addressed the comments * Update the recording after some change. * review changes * Test Update and Moved once condition. * lint * pylint again * Addressed the review comments * Updated the recording. * Changed the function name. * Flake8 fix * Updated the recording. * Updated the recording. * Update polling logic for PATCH function app * Rerun workload profile unit test * Consolidate dapr config and workload config updates * Use fake value in recording * Fetch cpu and memory only if resource config is not null * Revert resource config null check, add GET for all centauri apps created, update indexing --------- Co-authored-by: Kirstyn Joy Amperiadis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
The Consumption + Dedicated plan structure consists of a serverless plan that allows customer’s applications to scale in and out on demand. Applications can scale to zero, and you only pay for running apps.
Fully managed plan that customers can optionally use that provides dedicated, customized hardware to run apps on. Customers can select from general purpose and memory optimized workflow profiles that provide larger amounts of CPU and memory. You pay per node, versus per app, and workload profile can scale in and out as demand changes.
Testing Guide
Get environment names
az containerapp env show --name "<ENVIRONMENT_NAME>" --resource-group "<RESOURCE_GROUP>"Create a function app (note: --memory, --cpu and ---workload-profile-name are new flags)
az functionapp create -g <resource-group> -n <function-app-name> -s <storage-account-name> --environment <container-apps-environment-name> --runtime dotnet-isolated --functions-version 4 --memory 4.0gi --cpu 2.0 --workload-profile-name <work-load-profile-name>Then update the function app
az functionapp config container set --workload-profile-name <workload-profile-name> --memory 4.0gi --cpu 2.0This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.