Skip to content

[containerapp]: az containerapp update: Fix appending to NoneType object bug for --secret-volume-mount #27584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Greedygre wants to merge 1 commit into from
Closed

[containerapp]: az containerapp update: Fix appending to NoneType object bug for --secret-volume-mount #27584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,11 +496,11 @@ def update_containerapp_logic(cmd,
volume_mount_def["volumeName"] = volume_def["name"]
volume_mount_def["mountPath"] = secret_volume_mount

if "volumes" not in new_containerapp["properties"]["template"]:
if "volumes" not in new_containerapp["properties"]["template"] or new_containerapp["properties"]["template"]["volumes"] is None:
new_containerapp["properties"]["template"]["volumes"] = [volume_def]
else:
new_containerapp["properties"]["template"]["volumes"].append(volume_def)
c["volumeMounts"] = volume_mount_def
c["volumeMounts"] = [volume_mount_def]
else:
if len(c["volumeMounts"]) > 1:
raise ValidationError("Usage error: --secret-volume-mount can only be used with a container that has a single volume mount, to define multiple volumes and mounts please use --yaml")
Expand Down
Loading