return expires_on from get-access-token #27410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
requested review from
calvinhzy,
evelyn-ys and
jiasli
as code owners
❌AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
|
Hi @cataggar, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
zhoxing-ms
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
ARM
Member
|
Thanks for the contribution. I will discuss with our PMs regarding this topic. |
Member
|
@cataggar, do you prefer an integer
|
Member
Author
Member
|
As there are more things to do besides simply uncommenting this line, I will do these tasks in another PR #27476. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #19700. @jiasli made the code. It works. It will let us fix Azure/azure-sdk-for-rust#1371 .
If you want to rename it to
expiresOnEpoch, either works for us.Related command
az account get-access-token
Description
This returns the
expire_on.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
[ x The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.