Skip to content

{Packaging} Fix jp download url in ARM64 docker image #27269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebound merged 5 commits into from
Sep 12, 2023
Merged

{Packaging} Fix jp download url in ARM64 docker image #27269

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0018b0a
Minor fix
bebound Aug 17, 2023
544cfe5
Test
bebound Aug 17, 2023
08b1122
Merge branch 'dev' into fix-alpine-dockerfile
bebound Aug 28, 2023
747acb1
Minor fix
bebound Aug 28, 2023
048451d
Minor fix
bebound Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ RUN apk add --no-cache bash openssh ca-certificates jq curl openssl perl git zip
&& apk add --no-cache bash-completion \
&& update-ca-certificates

ARG JP_VERSION="0.1.3"
ARG JP_VERSION="0.2.1"
Copy link
Contributor Author

@bebound bebound Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no breaking change from 0.1.3 to 0.2.1
0.2.0 add jp-linux-arm64 release.
Ref: https://github.com/jmespath/jp/releases


RUN curl -L https://github.com/jmespath/jp/releases/download/${JP_VERSION}/jp-linux-amd64 -o /usr/local/bin/jp \
RUN arch=$(arch | sed s/aarch64/arm64/ | sed s/x86_64/amd64/) && curl -L https://github.com/jmespath/jp/releases/download/${JP_VERSION}/jp-linux-$arch -o /usr/local/bin/jp \
Copy link
Member

@jiasli jiasli Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually bad practice to include additional tools in the docker image. The image should be as small as possible.

Copy link
Contributor Author

@bebound bebound Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this image includes so many unrelated packages.
The image for Azure Linux is much smaller: #27204

Copy link
Member

@jiasli jiasli Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using sed to do the conversion is clever. I also saw this approach in https://stackoverflow.com/a/70369688/2199657.

&& chmod +x /usr/local/bin/jp

WORKDIR azure-cli
Expand Down