[Compute] az ppg update: Add new parameter --type to support setting proximity placement group type
#27241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
Compute |
microsoft-github-policy-service
bot
added
the
Compute
1 task
zhoxing-ms
reviewed
Aug 24, 2023
Comment on lines
-6724
to
-6725
| # fails because not a valid type | ||
| self.cmd('ppg create -n fail_ppg -g {rg} -t notAvalidType', expect_failure=True) |
Contributor
There was a problem hiding this comment.
May I ask why do you remove it?
Contributor
Author
There was a problem hiding this comment.
get_enum_type(self.get_models('ProximityPlacementGroupType')) will throw an error while passing the parameter instead of after executing the command，expect_failure will take effect after executing the command.
zhoxing-ms
approved these changes
Aug 29, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az ppg create/updateDescription
Support new value for PPG type parameter #26829
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.