[ARM] az bicep: Reflecting bicep cli updates to az bicep command
#26781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| bicep build-params | cmd bicep build-params added |
||
| bicep decompile-params | cmd bicep decompile-params added |
||
| bicep generate-params | cmd bicep generate-params added parameter include_params |
||
| bicep generate-params | cmd bicep generate-params added parameter output_format |
ghost
requested a review
from 
Collaborator
|
BICEP |
ghost
added
the
ARM
polatengin
changed the title
az bicep command
Member
|
@zhoxing-ms please could we have a review on this? |
shenglol
approved these changes
Jul 25, 2023
Member
Author
thanks for the approval @shenglol, I just updated the PR with linter/style fixes 👍 |
zhoxing-ms
changed the title
az bicep commandaz bicep: reflecting bicep cli updates to az bicep command
Contributor
|
@polatengin Please resolve these CLI linter issues~ |
Contributor
|
Please refer to the guideline to write the description of those PR changes in the |
Contributor
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 09-05) |
Contributor
|
@polatengin The CI failed because there is no tests for the new commands: Can you add some tests in https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource_custom.py? |
Contributor
You need to add some more specific descriptions for these new commands and parameters so that customers can understand these new features |
polatengin
changed the title
az bicep: reflecting bicep cli updates to az bicep commandaz bicep: Reflecting bicep cli updates to az bicep command
Member
Author
I added tests to the PR, all the pipelines are successfully run now 👍 I also updated the PR description Can you review this PR, please? /cc: @zhoxing-ms @yonzhan |
Contributor
|
@polatengin Please note that the parameters do not need to be written in the second command signature section, but should be written in the following description section. And the bicep module belongs to
Should be
|
Member
Author
I just updated the description of this PR, can you check please @zhoxing-ms ? |
zhoxing-ms
reviewed
Aug 17, 2023
zhoxing-ms
reviewed
Aug 17, 2023
zhoxing-ms
reviewed
Aug 17, 2023
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26781 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
@zhoxing-ms , @yonzhan I see all the checks are passing 🥳 can you review, please? |
zhoxing-ms
reviewed
Aug 28, 2023
Contributor
|
@polatengin Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 09-26) |
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Member
Author
hey @zhoxing-ms, I resolved all the comments. can you please check the PR and help me to merge it? |
zhoxing-ms
approved these changes
Aug 30, 2023
Contributor
|
This PR adds two On AMD64, it raises On ARM64, it raises Other tests which use bicep binary are live only. A quick fix is to change these tests to live only. AMD64 error logARM64 error log |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Following list of commands are added;
az bicep build-paramsaz bicep generate-paramsaz bicep decompile-paramsDescription
"bicep cli" got new command additions recently;
az bicep build-params: builds the given.bicepparamfile and creates '.parameters.json` fileaz bicep generate-params: generates a.bicepparamor.parameters.jsonfile, based on the--output-param {bicepparam, file}argument, from the given.bicepfileaz bicep decompile-params: generates a.bicepparamfile from the given.parameters.jsonfileHistory Notes
[ARM]
az bicep build-params: Support generatingparameters.jsonfile from the givenbicepparamfile with the--fileargument[ARM]
az bicep decompile-params: Support generatingparameters.bicepparamfile from the givenparameters.jsonfile with the--fileargument[ARM]
az bicep generate-params: Support generatingmain.parameters.jsonwith the parameters that doesn't have default values in the given.bicepfile[ARM]
az bicep generate-params: Add new parameter--output-formatto support generating parameter file inbicepparamandjsonformats[ARM]
az bicep generate-params: Add new parameter--include-paramsto support generating parameter file with all the parameters in the givenbicepfile, or with only parameters that doesn't have default values in the givenbicepfileThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
azdev style resourcecommand output;azdev linter resourcecommand output;