{Core} Copy login credential when run test with --live and random_config_dir is enabled
#26475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
ghost
requested review from
Collaborator
|
Core |
bebound
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz,
wangzelin007 and
zhoxing-ms
as code owners
bebound
changed the title
random_config_dir when record testrandom_config_dir when recording test
zhoxing-ms
previously approved these changes
May 18, 2023
jiasli
reviewed
May 18, 2023
| self.use_random_config_dir = True | ||
| else: | ||
| config_dir = GLOBAL_CONFIG_DIR | ||
| self.use_random_config_dir = False |
Member
There was a problem hiding this comment.
Won't this trigger failure when executed concurrently in live mode?
Contributor
Author
There was a problem hiding this comment.
That's a valid point. I need to copy login credentials then.
bebound
changed the title
random_config_dir when recording test--live and random_config_dir is enabled
bebound
commented
May 22, 2023
| if os.path.exists(GLOBAL_CONFIG_DIR): | ||
| ensure_dir(config_dir) | ||
| import shutil | ||
| for file in ['azureProfile.json', 'msal_token_cache.bin', 'clouds.config']: |
Contributor
Author
There was a problem hiding this comment.
@jiasli Are these files requires as login credential?
Member
There was a problem hiding this comment.
Service principal credentials are saved as service_principal_entries.bin:
If token encryption is disabled, .json is used as the file extension:
msal_token_cache.jsonservice_principal_entries.json
bebound
modified the milestones:
June 2023 (2023-07-04),
August 2023 (2023-09-05),
July 2023 (2023-08-01)
zhoxing-ms
reviewed
Jul 12, 2023
Comment on lines
+39
to
+40
| except FileNotFoundError: | ||
| pass |
Contributor
There was a problem hiding this comment.
I am not very familiar with the knowledge in the auth field, may I ask why do we pass for the FileNotFoundError?
Contributor
Author
There was a problem hiding this comment.
If the user is not logged in yet, these files do not exist in ~/.azure. Skip copying them.
3 tasks
wangzelin007
approved these changes
Sep 13, 2023
zhoxing-ms
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #26273 (comment), the login info can't be retrieved in recording mode when enable
random_config_dir,This PR copies the login credential from
~/.azureto random config dir.Related PR: #25689
Testing Guide
azdev test test_tag_update_by_patch --liveBefore:
FAILED src\azure-cli\azure\cli\command_modules\resource\tests\latest\test_resource.py::TagScenarioTest::test_tag_update_by_patch - knack.util.CLIError: Please run 'az login' to setup account.After:
Message: The client 'xxx' with object id 'xxx' does not have authorization to perform action 'Microsoft.Resources/subscriptions/resourcegroups/write' over scope '/subscriptions/axx' or the scope is invalid. If access was recently granted, please refresh your credentials.So it can read the token.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.