[Keyvault] BREAKING CHANGE: az keyvault create: --retention-days becomes required for MHSM creation
#26423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
ghost
added
the
ghost
requested a review
from 
Collaborator
|
Keyvault |
evelyn-ys
changed the title
az keyvault create: --retention-days becomes required for MHSM creationaz keyvault create: --retention-days becomes required for MHSM creation
evelyn-ys
modified the milestones:
June 2023 (2023-07-04),
May 2023 (2023-05-23) - For Build (Breaking change release)
evelyn-ys
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
necusjz
approved these changes
May 12, 2023
calvinhzy
approved these changes
May 17, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…becomes required for MHSM creation (Azure#26423) * az keyvault create: --retention-days becomes required for MHSM creation * fix network tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az keyvault createDescription
We won't set default retention days for MHSM creation anymore, customers need to specify this by themselves during creation
Testing Guide
az keyvault create --hsm-name {} --administrators {} --retention-days 7History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.