[IoT] az iot dps: Add support for managed identities within DPS
#26403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @vilit1, |
ghost
added
the
ghost
requested review from
Collaborator
|
IoT |
|
| is_break | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| iot dps create | cmd iot dps create added parameter identity_role |
||
| iot dps create | cmd iot dps create added parameter identity_scopes |
||
| iot dps create | cmd iot dps create added parameter system_identity |
||
| iot dps create | cmd iot dps create added parameter user_identities |
||
| iot dps identity | sub group iot dps identity added |
vilit1
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms and
necusjz
as code owners
Collaborator
|
Please fix CI issues first. |
Contributor
|
@vilit1 Could you please resolve these CI issues? |
Contributor
|
Please refer to the guideline to write the description of those PR changes in the |
zhoxing-ms
reviewed
Jun 26, 2023
Contributor
|
@vilit1 Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 08-01) |
Contributor
Author
This is ok. I can wait till the next release. |
vilit1
changed the title
az iot dps: Add support for managed identities within DPS
Contributor
Author
|
Feature may have been postponed - let me double check before closing this pr |
Contributor
Author
|
Feature is postponed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az iot dps createaz iot dps identityDescription
Addition of system and user assigned identity to DPS with the newer API version. The required sdk has been updated to point to the newer sdk.
Testing Guide
Created a new test - test_iot_dps_commands.py::IoTDpsTest::test_dps_identity_lifecycle
History Notes
[IoT]
az iot dps: Add support for managed identities within DPSThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.