-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ARM] Fix #26352: az ts create: Fix for the TypeError string indices must be integers
#26363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for the TypeError in az ts create CLi command fixes Azure#26352 While running the `az ts create` cli command we get the below error: ``` File "/home/sverrir/.local/lib/python3.10/site-packages/azure/cli/command_modules/resource/_packing_engine.py", line 155, in _get_template_links_to_artifacts deployment_resource_objs = _get_deployment_resource_objects(cmd, template_obj, includeNested) File "/home/sverrir/.local/lib/python3.10/site-packages/azure/cli/command_modules/resource/_packing_engine.py", line 140, in _get_deployment_resource_objects if (str(resource['type']) == 'Microsoft.Resources/deployments') is True: TypeError: string indices must be integers ``` This PR has the fix for this issue.
️✔️AzureCLI-FullTest
|
Collaborator
|
AzureResourceManager |
az ts create: Fix for the TypeError string indices must be integers
Contributor
|
@navba-MSFT Could you please add a test for this case? |
Contributor
|
@shenglol Could you please help review the |
shenglol
reviewed
May 11, 2023
shenglol
approved these changes
May 17, 2023
Contributor
shenglol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
zhoxing-ms
approved these changes
May 18, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…indices must be integers` (Azure#26363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARM
az resource/group/lock/tag/deployment/policy/managementapp/account management-group
Auto-Assign
Auto assign by bot
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for the TypeError in az ts create CLi command
fixes #26352
While running the
az ts createcli command we get the below error:This PR has the fix for this issue.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.