[Sqlvm] az sql vm enable-azure-ad-auth/validate-azure-ad-auth: Single mode improvement
#26133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2023 19:54
deprecated. Now there is no management mode concept in SQL VM.
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
azure-client-tools-bot-prd
bot
added this to the
May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Hi @qianliu-pdx, |
ghost
added
ghost
requested review from
Collaborator
|
Sqlvm |
evelyn-ys
changed the title
az sql vm enable-azure-ad-auth/validate-azure-ad-auth: client change to accommodate the single mode improvement
evelyn-ys
approved these changes
Apr 13, 2023
evelyn-ys
modified the milestones:
May 2023 (2023-05-23) - For Build (Breaking change release),
April 2023 (2023-04-25)
evelyn-ys
changed the title
az sql vm enable-azure-ad-auth/validate-azure-ad-auth: client change to accommodate the single mode improvementaz sql vm enable-azure-ad-auth/validate-azure-ad-auth: Single mode improvement
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…le mode improvement (Azure#26133) * remove the validation of SQL VM management mode because it is deprecated. Now there is no management mode concept in SQL VM. * fix the test --------- Co-authored-by: Qiang Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sql vm enable-azure-ad-auth
az sql vm validate-azure-ad-auth
Description
SQL VM used to have the management mode concept and most management functionalities can only be done in the "Full" management mode. The above two commands do client side validation of the management mode and reject the request if it is not "Full". Recently, SQL VM removed this management mode concept externally. Internally it does automatic upgrade to "Full" mode upon any management request which needs the "Full" mode in place. Therefore there is no need to validate the management mode from the client side anymore. This PR is to remove this validation.
Testing Guide
The automatic test "test_sqlvm_aad_auth_negative" is modified to cover the modification from this PR. In this test, we removed the management mode parameter when creating SQL VM resource and validated that the validation has been in effect removed.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.