[SQL] az sql midb ledger-digest-uploads: Support SQL Ledger
#26043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
ghost
added
Collaborator
|
MI |
ghost
requested a review
from 
evelyn-ys
reviewed
Apr 4, 2023
| text: az sql midb log-replay wait --deleted --resource-group mygroup --managed-instance myinstance --name mymanageddb | ||
| """ | ||
|
|
||
| helps['sql midb ledger-digest-uploads'] = """ |
Member
There was a problem hiding this comment.
Suggested change
| helps['sql midb ledger-digest-uploads'] = """ | |
| helps['sql midb ledger-digest-upload'] = """ |
Contributor
Author
There was a problem hiding this comment.
we use same cmd in azure sql also. So, using the same to maintain the consistency between azure sql and MI.
https://learn.microsoft.com/en-us/cli/azure/sql/db/ledger-digest-uploads?view=azure-cli-latest#az-sql-db-ledger-digest-uploads-enable
evelyn-ys
previously approved these changes
Apr 4, 2023
Member
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
Please add tests for new commands
evelyn-ys
reviewed
Apr 6, 2023
| expect_failure=True) | ||
|
|
||
| @ManagedInstancePreparer() | ||
| def test_sql_midb_ledger(self, mi, rg): |
Member
There was a problem hiding this comment.
After adding test, pls commit the test recording file too.
Contributor
Author
There was a problem hiding this comment.
Added test recordings.
paramsiva1
changed the title
az sql midb ledger-digest-uploads: Support SQL Ledger
added 2 commits
April 11, 2023 17:25
evelyn-ys
approved these changes
Apr 12, 2023
evelyn-ys
changed the title
az sql midb ledger-digest-uploads: Support SQL Ledgeraz sql midb ledger-digest-uploads: Support SQL Ledger
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…26043) * CLI support for ledger in MI * changes * add test for create api * tests and recordings * fix spaces * update test recordings --------- Co-authored-by: Parameswara Reddy Bodeddula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sql midb createaz sql midb ledger-digest-uploadsDescription
Adding Azure CLI commands for Ledger in MI (az sql midb ledger-digest-uploads).
Adding parameter to az sql midb create for ledger database
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.