[EventHub] az eventhubs namespace application-group policy remove: Add upcoming breaking change notification
#26041
Conversation
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
ghost
added
ghost
requested a review
from 
|
EventHub |
schaudhari6254888
changed the title
az eventhubs namespace application-group policy remove: Adding breaking change in az eventhubs namespace application-group policy remove cmdletaz eventhubs namespace application-group policy remove: Add breaking change message for az eventhubs namespace application-group policy remove command
|
Can someone please review & merge this pull request. Only contain the breaking change alert message |
|
If the "breaking change" you mentioned is "metric-id,rate-limit-threshold would not be required", then I don't think it breaks anything. So you can just modify the title & description with Add warning for balabala |
Co-authored-by: Yishi Wang <[email protected]>
Since we are using this parameters while removing the policy name previously. |
|
When will you deprecate these parameters? The code change seems nothing to do with the breaking change... Just FYI, CLI only allows breaking change twice a year and next breaking change window is May release |
Inside the --throttling-policy-config object these parameters are present for removal policy. |
|
So this PR is not related with this breaking change, right? Can you modify the PR title and description? |
schaudhari6254888
changed the title
az eventhubs namespace application-group policy remove: Add breaking change message for az eventhubs namespace application-group policy remove commandaz eventhubs namespace application-group policy remove command
This PR, I am only giving Message notification. |
| appGroup = client.get(resource_group_name, namespace_name, application_group_name) | ||
|
|
||
| logger.warning( | ||
| 'This operation will do removals based on policy name') |
There was a problem hiding this comment.
I don't think with this message customers are able to realize there will be breaking change in the future......
It just says policy name will be used for removals
There was a problem hiding this comment.
If you want to notify that you won't accept metric-id,rate-limit-threshold in the future, pls say it explicitly
There was a problem hiding this comment.
Hey @evelyn-ys , Sorry for the inconvenience.
Does the Description & warning message makes the good sense now?
Any suggestions are always welcome.
evelyn-ys
changed the title
az eventhubs namespace application-group policy remove commandaz eventhubs namespace application-group policy remove: Add upcoming breaking change notification
…Add upcoming breaking change notification (Azure#26041) * Breaking change * updates * CI's fixed * Update src/azure-cli/azure/cli/command_modules/eventhubs/custom.py Co-authored-by: Yishi Wang <[email protected]> * Updates * Updates --------- Co-authored-by: Yishi Wang <[email protected]>
4 participants
Related command
az eventhubs namespace application-group policy removeDescription
Removing parameters metric-id, rate-limit-threshold from --throttling-policy-config object only for
az eventhubs namespace application-group policy removecommand.Additionally changing
throttling-policy-configname topolicy, foraz eventhubs namespace application-group policy removecommand.The change will release in Upcoming breaking change cycle i.e May.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.