Skip to content

rbac: catch more graph errors before retry #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yugangw-msft merged 1 commit into from
Mar 21, 2017
Merged

rbac: catch more graph errors before retry #2567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-role/azure/cli/command_modules/role/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ def create_service_principal_for_rbac(name=None, password=None, years=1, #pylint
break
except Exception as ex: #pylint: disable=broad-except
#pylint: disable=line-too-long
if l < _RETRY_TIMES and 'The appId of the service principal does not reference a valid application object' in str(ex):
if l < _RETRY_TIMES and (' does not reference ' in str(ex) or ' does not exist ' in str(ex)):
time.sleep(5)
logger.warning('Retrying service principal creation: %s/%s', l+1, _RETRY_TIMES)
else:
Expand Down