{Core} az login: Add extra empty line to separate the tenant warning from output
#25564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
Currently, if some tenant contains no accessible subscription, Azure CLI shows a warning as below:
However, it can confuse the user and make the user think the JSON contains inaccessible tenants.
This PR adds an extra empty line to separate the warning from output.
Per my understanding, a better place to show the warning is after the JSON, in the post-output hint (#16242), since if the JSON is very long, it will "flood" the warning message. The user will have to scroll all the way up to see it. However, the post-output hint feature along with its implementation detail is still under discussion.