Skip to content

Conversation

@tspearconquest
Copy link
Contributor

… and pyOpenSSL to 23.0.0

Related command

Description

Azure-CLI dependency: cryptography v38.0.4 has a CVE, this release of cryptography patches the CVE

Testing Guide

cryptography v38.0.4 has a CVE and v39.0.1 is no longer compatible with OpenSSL 1.x releases. All users must upgrade OpenSSL to 3.x to continue using the CLI

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

… and pyOpenSSL to 23.0.0

Signed-off-by: Thomas Spear <[email protected]>
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 23, 2023
@ghost
Copy link

ghost commented Feb 23, 2023

Thank you for your contribution tspearconquest! We will review the pull request and get back to you soon.

@tspearconquest
Copy link
Contributor Author

@microsoft-github-policy-service agree

1 similar comment
@tspearconquest
Copy link
Contributor Author

@microsoft-github-policy-service agree

@yonzhan yonzhan requested review from bebound and jiasli February 23, 2023 03:46
@yonzhan yonzhan added this to the Feb 2023 (2023-03-07) milestone Feb 23, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 23, 2023

Add @bebound for awareness

@jiasli jiasli changed the title [Misc.] BREAKING CHANGE: Patch CVE in cryptography package by upgrading cryptography to 39.0.1… [Packaging] Bump cryptography to 39.0.1 and pyOpenSSL to 23.0.0 Feb 23, 2023
@jiasli jiasli changed the title [Packaging] Bump cryptography to 39.0.1 and pyOpenSSL to 23.0.0 {Packaging} Bump cryptography to 39.0.1 and pyOpenSSL to 23.0.0 Feb 23, 2023
@jiasli
Copy link
Member

jiasli commented Feb 23, 2023

Thank you for your contribution @tspearconquest. The PR looks good. I will merge it once CI passes.

@bebound
Copy link
Contributor

bebound commented Feb 23, 2023

cryptography has built-in openssl, which is cryptography\hazmat\bindings\_openssl.pyd

import cryptography.hazmat.backends.openssl.backend
cryptography.hazmat.backends.openssl.backend.openssl_version_text()
>>> 'OpenSSL 3.0.8 7 Feb 2023'

import ssl
ssl.OPENSSL_VERSION
>>> 'OpenSSL 1.1.1q  5 Jul 2022'

Ref: https://cryptography.io/en/39.0.1/openssl/#cryptography.hazmat.backends.openssl.openssl_version_text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants