Skip to content

[ACS] Provide a short name alias for the orchestrator type flag #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Troy Dai (troydai) merged 2 commits into from
Mar 20, 2017
Merged

[ACS] Provide a short name alias for the orchestrator type flag #2553

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b26ad
[ACR] Provide a short name alias for the orchestrator type flag
lostintangent Mar 18, 2017
c5749e3
Correct typo
lostintangent Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def _get_default_install_location(exe_name):
register_cli_argument('acs', 'name', arg_type=name_arg_type, help='ACS cluster name', completer=get_resource_name_completion_list('Microsoft.ContainerService/ContainerServices'))
register_cli_argument('acs', 'resource_group', arg_type=resource_group_name_type)

register_cli_argument('acs', 'orchestrator_type', **enum_choice_list(ContainerServiceOchestratorTypes))
register_cli_argument('acs', 'orchestrator_type', options_list=('--orchestrator_type', '-t'), **enum_choice_list(ContainerServiceOchestratorTypes))

@troydai Troy Dai (troydai) Mar 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the long name simply be --type?

@lostintangent Jonathan Carter (lostintangent) Mar 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Troy Dai (@troydai) I would totally be in favor of that! I just wasn't sure if that would be a breaking change worth doing (did the ACS module GA already?). Let me know what you think and I'm happy to make that change.

@troydai Troy Dai (troydai) Mar 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. We can't do this breaking change. Ideally, we can do multiple aliases for one parameter, however this would further confusing the namespace. Let's keep the name for now. We can think of a way to introduce obsoleted parameter if necessary.

In addition, the parameter should be registered as --orchestrator-type instead of --orchestrator_type.

@lostintangent Jonathan Carter (lostintangent) Mar 20, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I didn't realize I introduced that typo :) Fixed!

# some admin names are prohibited in acs, such as root, admin, etc. Because we have no control on the orchestrators, so default to a safe name.
register_cli_argument('acs', 'admin_username', options_list=('--admin-username',), default='azureuser', required=False)
register_cli_argument('acs', 'dns_name_prefix', options_list=('--dns-prefix', '-d'))
Expand Down