{Packaging} Bump paramiko to 3.0.0

[StrawnSC]

Related command

Seems to impact all web app commands (and possibly all app service commands).

Description

Fixes #25406. One of our dependencies (I believe for an ssh command), paramiko, was using a deprecated library, blowfish. Whenever a user runs a webapp command, it outputs a message about blowfish being deprecated. Fortunately, this was fixed in pamiko version 2.11.0.

Testing Guide

az webapp list --query "[].name"
This command should no longer output a deprecation warning for blowfish

History Notes

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[StrawnSC]

@zhoxing-ms I think we'll need to coordinate with the owners of the VM command module. This change in package version is causing a failure in the test test_vmss_reimage_instance_id(it also fails when I try to run in live mode)

[yonzhan]

App Service

[zhoxing-ms]

@StrawnSC I submitted a PR #25477 to fix this issue

[jiasli]

For the CI failure:

https://dev.azure.com/azclitools/public/_build/results?buildId=34377&view=logs&jobId=30ea7d53-004d-5bd2-a621-b8181c819a0a&j=30ea7d53-004d-5bd2-a621-b8181c819a0a&t=47172527-53e4-5dcb-851a-2758f30ab117

    def tearDown(self):
        os.environ = self.original_env
        # Autorest.Python 2.x
        assert not [t for t in threading.enumerate() if t.name.startswith("AzureOperationPoller")], \
            "You need to call 'result' or 'wait' on all AzureOperationPoller you have created"
        # Autorest.Python 3.x
>       assert not [t for t in threading.enumerate() if t.name.startswith("LROPoller")], \
            "You need to call 'result' or 'wait' on all LROPoller you have created"
E       AssertionError: You need to call 'result' or 'wait' on all LROPoller you have created
...
FAILED src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py::VMSSReimageScenarioTest::test_vmss_reimage_instance_id

This is a typical failure caused by not-returned pollers:

azure-cli/src/azure-cli/azure/cli/command_modules/vm/custom.py

Lines 3710 to 3711 in 96a3e47

	sdk_no_wait(no_wait, client.virtual_machine_scale_set_vms.begin_reimage,
	resource_group_name, vm_scale_set_name, instance)

It happened before in #21974

I also encountered the same failure in #25452

#25477 will fix the broken test_vmss_reimage_instance_id test.

[jiasli]

Perhaps we can bump to 3.0.0? https://pypi.org/project/paramiko/

[gukoff]

JFYI azure-cli-core currently requires a version <3.0.0

https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/setup.py#L59

Maybe @marstr remembers why

[marstr]

Wow, this is a blast from the past! Unfortunately, I can't remember the rationale behind this restriction. Best of luck.

[bebound]

paramiko<3.0.0 is introduced in #9668. It looks like a general update and pin it to version 2.xx to prevent breaking changes.

I update it to 3.0.0 in this branch, and the tests are passed.

[bebound]

@StrawnSC Could you please update paramiko to 3.0.0 and change this line to <4.0.0 https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/setup.py#L59