Skip to content

Conversation

@bebound
Copy link
Contributor

@bebound bebound commented Feb 7, 2023

Description

In Azure/azure-cli-dev-tools#351, Flake8 is upgrade to 6.0, and the old .flake8 is not compatible.

Flake8 does not support inline comments for any of the keys -- https://flake8.pycqa.org/en/6.0.0/user/configuration.html

I put comments to new lines.

Without this PR, this error is raised.

╰─ azdev style redis                                                                                                                        ─╯

===============
| Style Check |
===============

Modules: redis

Running pylint on modules...
Pylint: PASSED

Running flake8 on modules...
Traceback (most recent call last):
  File "C:\Users\kk\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\kk\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\__main__.py", line 7, in <module>
    raise SystemExit(main())
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\main\cli.py", line 23, in main
    app.run(argv)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\main\application.py", line 198, in run
    self._run(argv)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\main\application.py", line 186, in _run
    self.initialize(argv)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\main\application.py", line 165, in initialize
    self.plugins, self.options = parse_args(argv)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\options\parse_args.py", line 53, in parse_args
    opts = aggregator.aggregate_options(option_manager, cfg, cfg_dir, rest)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\options\aggregator.py", line 30, in aggregate_options
    parsed_config = config.parse_config(manager, cfg, cfg_dir)
  File "C:\Users\kk\Developer\azure-cli\venv\lib\site-packages\flake8\options\config.py", line 131, in parse_config
    raise ValueError(
ValueError: Error code 'W504#' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$'

This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added Auto-Assign Auto assign by bot CI CI labels Feb 7, 2023
@ghost ghost requested review from jiasli, jsntcy, kairu-ms, wangzelin007 and yonzhan February 7, 2023 07:49
@ghost ghost assigned wangzelin007 Feb 7, 2023
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 7, 2023
@ghost ghost added the Redis Cache label Feb 7, 2023
@ghost ghost requested a review from evelyn-ys February 7, 2023 07:50
@ghost ghost assigned evelyn-ys Feb 7, 2023
@ghost ghost requested a review from zhoxing-ms February 7, 2023 07:50
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 7, 2023

CI

@bebound bebound marked this pull request as ready for review February 7, 2023 08:59
@bebound bebound merged commit 669f7c9 into dev Feb 8, 2023
@bebound bebound deleted the update-flake8 branch February 8, 2023 07:47
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
@bebound bebound mentioned this pull request Aug 24, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot CI CI Redis Cache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants