[Compute] az vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removed
#25283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
zhoxing-ms
changed the title
az vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removed
Collaborator
|
Compute warning refinement |
zhoxing-ms
changed the title
az vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removedaz vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removed
zhoxing-ms
changed the title
az vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removedaz vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removed
zhoxing-ms
changed the title
az vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removedaz vm/vmss identity assign: Add warning log and modify help to inform that the default value Contributor of --role will be removed
Contributor
Author
|
@dcaro Could you please help review this PR? |
Contributor
|
@zhoxing-ms can you reuse the messages that have been discussed in #24755 ? |
zhoxing-ms
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
Contributor
Author
Contributor
|
@dcaro, From a doc's perspective, there are 770 GitHub lines that have various combinations of |
yanzhudd
reviewed
Mar 2, 2023
yanzhudd
reviewed
Mar 2, 2023
yanzhudd
approved these changes
Mar 2, 2023
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️natgateway
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
jsntcy
approved these changes
Mar 3, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…lp to inform that the default value Contributor of `--role` will be removed (Azure#25283)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm/vmss identity assignDescription
Similar to #20924
As the security team raised the security concern: the permission of
Contributoris too high to be used as the default role foraz vm/vmss identity assign, so the default valueContributorof--rolewill be removed in the future.Therefore, the first step is to prompt users that parameters
--roleand--scopeshould be passed in at the same time when assigning role to the managed identity to reduce the impact of breaking change.The specific effects are as follows:
warning message
help message
help example
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.