Skip to content

Conversation

@oakeyc
Copy link
Contributor

@oakeyc oakeyc commented Mar 15, 2017

No description provided.

@msftclas
Copy link

@oakeyc,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #2521 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
- Coverage   72.27%   72.26%   -0.01%     
==========================================
  Files         362      362              
  Lines       19671    19673       +2     
  Branches     2897     2898       +1     
==========================================
  Hits        14217    14217              
- Misses       4539     4541       +2     
  Partials      915      915
Impacted Files Coverage Δ
...azure-cli-core/azure/cli/core/commands/__init__.py 79.68% <0%> (-0.51%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a74f6...1e1803d. Read the comment docs.

@troydai
Copy link
Contributor

troydai commented Mar 15, 2017

@oakeyc Does this change relate to 1917ba7?

@oakeyc
Copy link
Contributor Author

oakeyc commented Mar 15, 2017

@troydai, yes. The other change broke the tab-completion in the cli, but I still need access to the choice list, but this doesn't break the tab-completion

@tjprescott tjprescott requested a review from derekbekoe March 16, 2017 16:59
@tjprescott tjprescott merged commit 06a3297 into Azure:master Mar 16, 2017
@oakeyc oakeyc deleted the choice_list branch March 16, 2017 17:22
thegalah pushed a commit to thegalah/azure-cli that referenced this pull request Mar 21, 2017
* Azure/master: (478 commits)
  vm live test: allow more valid power states on vmss test verifications (Azure#2564)
  rbac:catch more graph error (Azure#2567)
  appservice: support to create plan when create a webapp (Azure#2550)
  Update storage tests (Azure#2556)
  Change PEP8 check filter from whitelist to blacklist (Azure#2557)
  Add scenario tests documentation (Azure#2555)
  [ACS] Adding support for configuring a default ACS cluster (Azure#2554)
  [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553)
  Sql Import/Export CLI commands and test (Azure#2538)
  Fix format bug. (Azure#2549)
  [VM/VMSS] Improved disk caching support (Azure#2522)
  VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537)
  Script that creates packaged releases package archive (Azure#2508)
  Adding alias for defaults flag (Azure#2540)
  Add wait commands and --no-wait support (Azure#2524)
  choice list outside of named arguments (Azure#2521)
  Fixed test failure in test_sql_db_mgmt. (Azure#2530)
  core: support login using service principal with a cert (Azure#2457)
  Add note about being in preview (Azure#2512)
  vm:fix distro check mechanism used by disk encryption (Azure#2511)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants