Skip to content

Conversation

@PramodValavala-MSFT
Copy link
Contributor

Related command

az servicebus queue update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection --enable-session
az servicebus topic update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection
az servicebus topic subscription update --resource-group {} --namespace-name {} --name {} --enable-session

Description

The following properties of an entity cannot be updated post creation but the update the commands for entities have these arguments, which are invalid and fail as such

  • Partitioning (Queues & Topics)
  • Duplicate Detection (Queues & Topics)
  • Sessions (Queues & Subscriptions)

This PR removes the arguments for the update commands.

resolves #24741

Testing Guide

az servicebus queue update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection --enable-session
az servicebus topic update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection
az servicebus topic subscription update --resource-group {} --namespace-name {} --name {} --enable-session

The above commands currently fail with a 400 Bad Request, which is expected due to the invalid arguments that can't be updated post entity creation. With this PR, they should be removed from the documentation, command help, and error as invalid arguments directly.

History Notes

[ServiceBus] az servicebus queue update: Remove invalid arguments for queue update command
[ServiceBus] az servicebus topic update: Remove invalid arguments for topic update command
[ServiceBus] az servicebus topic subscription update: Remove invalid arguments for subscription update command


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added Auto-Assign Auto assign by bot Service Bus az servicebus labels Dec 2, 2022
@ghost ghost requested review from calvinhzy, evelyn-ys and yonzhan December 2, 2022 18:52
@ghost ghost assigned evelyn-ys Dec 2, 2022
@ghost ghost added this to the Dec 2022 (2023-01-03) milestone Dec 2, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 3, 2022

ServiceBus

@damodaravadhani
Copy link
Member

Hi @PramodValavala-MSFT , thanks for working on this. There might need to be testcase updates that need to be made to this, I can take this from here if you invite me as a collaborator on your azure-cli fork.

@PramodValavala-MSFT
Copy link
Contributor Author

@damodaravadhani Sure. I've added you as a contributor to my fork. Let me know what tests you have in mind and I could help out too, if needed.

@evelyn-ys
Copy link
Member

Hi @PramodValavala-MSFT , this is breaking change and we only allow breaking change twice a year. Can you add deprecation and warnings for now and totally remove them in next breaking change window?

@evelyn-ys
Copy link
Member

Oh I've already seen #24937 adding the deprecation warning. I'll close this PR then

@evelyn-ys evelyn-ys closed this Dec 29, 2022
@PramodValavala-MSFT PramodValavala-MSFT added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Bus az servicebus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

az servicebus queue create and az servicebus queue update ignore --enable-partitioning

4 participants