Skip to content

[Role] az ad sp create-for-rbac: Drop no-op argument --skip-assignment #24729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiasli wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[Role] az ad sp create-for-rbac: Drop no-op argument --skip-assignment #24729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06378a9
skip-assignment
jiasli Nov 24, 2022
4511049
test
jiasli Nov 24, 2022
de816a4
Merge remote-tracking branch 'azure/dev' into skip-assignment
jiasli Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/azure-cli/azure/cli/command_modules/role/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ def load_arguments(self, _):
"/subscriptions/0b1f6471-1bf0-4dda-aec3-111122223333/resourceGroups/myGroup/providers/Microsoft.Compute/virtualMachines/myVM")
c.argument('role', completer=get_role_definition_name_completion_list,
help='Role of the service principal.')
c.argument('skip_assignment', arg_type=get_three_state_flag(),
deprecate_info=c.deprecate(target='--skip-assignment', hide=True), help='No-op.')
c.argument('show_auth_for_sdk', options_list='--sdk-auth', deprecate_info=c.deprecate(target='--sdk-auth'),
help='output result in compatible with Azure SDK auth file', arg_type=get_three_state_flag())

Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/role/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,9 +1148,9 @@ def list_service_principal_owners(client, identifier):

# pylint: disable=inconsistent-return-statements
def create_service_principal_for_rbac(
# pylint:disable=too-many-statements,too-many-locals, too-many-branches, unused-argument
# pylint:disable=too-many-statements,too-many-locals, too-many-branches
cmd, display_name=None, years=None, create_cert=False, cert=None, scopes=None, role=None,
show_auth_for_sdk=None, skip_assignment=False, keyvault=None):
show_auth_for_sdk=None, keyvault=None):
import time

if role and not scopes or not role and scopes:
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/role/tests/latest/test_role_commands_thru_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ def test_create_for_rbac_retry(self, create_application_mock, create_service_pri
cmd = mock.MagicMock()
cmd.cli_ctx = DummyCli()
with mock.patch("time.sleep", lambda _: None):
create_service_principal_for_rbac(cmd, skip_assignment=True)
create_service_principal_for_rbac(cmd)


if __name__ == '__main__':
Expand Down