Skip to content

[IoT] Increase SDK and API version#24261

Merged
zhoxing-ms merged 10 commits into
Azure:devfrom
vilit1:iot_sdk_update2
Nov 11, 2022
Merged

[IoT] Increase SDK and API version#24261
zhoxing-ms merged 10 commits into
Azure:devfrom
vilit1:iot_sdk_update2

Conversation

@vilit1
Copy link
Copy Markdown
Contributor

@vilit1 vilit1 commented Oct 18, 2022

Related command

az iot hub
az iot hub create
az iot hub route test
az iot dps linked-hub create

Description
Increase the API version to 2022-04-30-preview and pin the min SDK to azure-mgmt-iothub==2.3.0. This will enable customers to modify the control plane of hubs that have features from the 2022-04-30-preview API, specifically the Cosmos DB endpoints.

The Cosmos DB Endpoint feature will be released in the azure iot extension.

There is also some small fixes:

  1. the fileupload_storage_container_uri parameter is no longer used and is removed in this pr. This will remove the warning message below that occurs during hub creation.
    image
  2. the app_properties and system_properties for hub routes will now be converted to a dictionary (and thus make the routes test work)
  3. the dps linked hub will now have an error message about location - so that if a hub is provided in a different subscription, then the user will be prompted to give the location. This will fix the customer confusion as seen in this issue: az iot dps linked-hub create hub and DPS on different subscriptions broken!? #22257
  4. Add preview to device streams as part of Mark DeviceStreams commands as Preview #24554
  5. Fix a networking test in which az iot device-update was renamed to az iot du
  6. Add no wait to iot hub create and delete

Testing Guide

Regenerated all affected iot commands. Also added a test to route test (that would have failed in the older version)

History Notes

[IoT] Fix #22257: az iot dps linked-hub create: Improve error handling for linked hubs
[IoT] az iot hub create/delete: Add --no-wait parameter to support no wait operation


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the Auto-Assign Auto assign by bot label Oct 18, 2022
@ghost ghost requested review from wangzelin007 and yonzhan October 18, 2022 21:40
@ghost ghost assigned zhoxing-ms Oct 18, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 18, 2022
@ghost ghost added IoT IoT/CLI labels Oct 18, 2022
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 18, 2022

IoT Hub

Comment thread src/azure-cli-core/azure/cli/core/profiles/_shared.py
Comment thread src/azure-cli/azure/cli/command_modules/iot/commands.py
@zhoxing-ms
Copy link
Copy Markdown
Contributor

zhoxing-ms commented Nov 8, 2022

[IoT Hub] Increase min SDK and API version
[IoT Hub] Remove warning during Hub creation and fix routes test
[IoT Dps] Improve error handling for linked hubs

We usually only write the changes that can be perceived by users and affect users' business in the history notes, so I personally think the first and second points can be deleted.
Could you describe the third point in more detail?

@vilit1
Copy link
Copy Markdown
Contributor Author

vilit1 commented Nov 8, 2022

[IoT Hub] Increase min SDK and API version
[IoT Hub] Remove warning during Hub creation and fix routes test
[IoT Dps] Improve error handling for linked hubs

We usually only write the changes that can be perceived by users and affect users' business in the history notes, so I personally think the first and second points can be deleted. Could you describe the third point in more detail?

  1. the dps linked hub will now have an error message about location - so that if a hub is provided in a different subscription, then the user will be prompted to give the location. This will fix the customer confusion as seen in this issue: az iot dps linked-hub create hub and DPS on different subscriptions broken!? #22257

The second point will affect users too:

  1. the fileupload_storage_container_uri parameter is no longer used and is removed in this pr. This will remove the warning message below that occurs during hub creation.
    image
  2. the app_properties and system_properties for hub routes will now be converted to a dictionary (and thus make the routes test work)

@zhoxing-ms zhoxing-ms changed the title [IoT Hub] Increase SDK and API version [IoT] Increase SDK and API version Nov 9, 2022
@zhoxing-ms
Copy link
Copy Markdown
Contributor

The second point will affect users too

In fact, the warning log has no real impact on the user's business, so we usually do not write the changes of warning log into the history notes.

[IoT] Fix #22257: az iot dps linked-hub create: Improve error handling for linked hubs

This is my updated history note, please see if it meets your expectations

@zhoxing-ms zhoxing-ms merged commit 9ef066f into Azure:dev Nov 11, 2022
@vilit1 vilit1 mentioned this pull request Aug 22, 2023
3 tasks
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
@vilit1 vilit1 mentioned this pull request Oct 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

az iot dps linked-hub create hub and DPS on different subscriptions broken!?

6 participants