[AKS] az aks nodepool add: Add option Windows2019, Windows2022 to --os-sku parameter
#23715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiqianTao
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
assigned
Contributor
Author
|
Hi @AbelHu @FumingZhang , could you help to review this PR? Thank you. |
Collaborator
|
AKS |
zhoxing-ms
changed the title
Windows2019, Windows2022 to --os-sku for az aks nodepool addaz aks nodepool add: Add option Windows2019, Windows2022 to --os-sku parameter
zhoxing-ms
approved these changes
Aug 30, 2022
AbelHu
approved these changes
Aug 30, 2022
Contributor
Author
|
Hi @zhoxing-ms Could you help to merge this PR? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AKS] Add option
Windows2019,Windows2022to--os-skuforaz aks nodepool addMigrate from Azure CLI extension aks-preview: Azure/azure-cli-extensions#4549
Related command
az aks nodepool add --os-type Windows --os-sku Windows2019az aks nodepool add --os-type Windows --os-sku Windows2022Description
Customers can use this parameter to select OSSKU when creating Windows node pools.
Testing Guide
azdev test --live test_aks_nodepool_add_with_ossku_windows2022
History Notes
N/A
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.