{Auth} Show device code message regardless of core.only_show_errors config option
#23647
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
evelyn-ys
approved these changes
Aug 24, 2022
Member
Author
|
Interesting thing is that at the very beginning 6beafec#diff-cab8e9aacb616771cc8bc960f81835d6b768d2438a8b9e5ea188319702c1acbeR39 #210 then switched to 0922c6e#diff-51f92645190e8ca2270fc0f699228ffe4d39e89c2a05b68832a09b1be3a47cd3R242 |
This was referenced Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23320
Related command
az loginDescription
Currently device code message is printed using
logger.warningwhich is controlled bycore.only_show_errorsconfig option. Ifcore.only_show_errorsis set totrue, device code message will be hidden.This PR switches to
print_styled_textso that device code message is printed directly tosys.stderr, regardless ofcore.only_show_errorsconfig option.Testing Guide