Skip to content

[Storage] Fix #22679: az storage account file-service-properties update: Fix AttributeError: 'NoneType' object has no attribute 'smb' #22691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 1 commit into from
Jun 7, 2022
Merged

[Storage] Fix #22679: az storage account file-service-properties update: Fix AttributeError: 'NoneType' object has no attribute 'smb' #22691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/azure-cli/azure/cli/command_modules/storage/operations/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,8 @@ def update_file_service_properties(cmd, instance, enable_delete_retention=None,
params['share_delete_retention_policy'] = instance.share_delete_retention_policy

# set protocol settings
if not instance.protocol_settings or not instance.protocol_settings.smb:
instance.protocol_settings = cmd.get_models('ProtocolSettings')(smb=cmd.get_models('SmbSetting')())
if enable_smb_multichannel is not None:
instance.protocol_settings.smb.multichannel = cmd.get_models('Multichannel')(enabled=enable_smb_multichannel)

Expand All @@ -760,7 +762,7 @@ def update_file_service_properties(cmd, instance, enable_delete_retention=None,
instance.protocol_settings.smb.kerberos_ticket_encryption = kerberos_ticket_encryption
if channel_encryption is not None:
instance.protocol_settings.smb.channel_encryption = channel_encryption
if any(instance.protocol_settings.smb.__dict__.values()):
if instance.protocol_settings and instance.protocol_settings.smb and any(instance.protocol_settings.smb.__dict__.values()):
params['protocol_settings'] = instance.protocol_settings

return params
Expand Down
Loading