[ARM] az resourcemanagement private-link and az private-link association: Add new command groups
#22064
Conversation
ghost
requested review from
ghost
added
the
ARM
yonzhan
removed
the
ARM
|
private links |
tjegbejimba
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy and
kairu-ms
as code owners
tjegbejimba
changed the title
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
modified the milestones:
Apr 2022 (2022-04-26),
May 2022 (2022-05-24) - For Build
|
@tjegbejimba Please address these CI issues |
|
In addition, if you want to write multiple descriptions in the history note, please refer to submitting-pull-requests and write it in the |
|
@tjegbejimba Since this PR was submitted late, it cannot catch up with the release of this sprint. We will plan to release it in the next sprint (05-24), is this time acceptable? |
|
It is recommended not to modify the format of these files, which will lead to too many irrelevant changes in this PR |
This reverts commit fa18172.
|
Sorry, you still need to solve the linter issue (I didn't aware you changed so many code styles to solve the linter issue, I thought it was the automatic formatting from IDE) |
Co-authored-by: Xing Zhou <[email protected]>
Co-authored-by: Xing Zhou <[email protected]>
zhoxing-ms
changed the title
az resourcemanagement private-link and az private-link association: Add new command groups
| { | ||
| "Command": "az resourcemanagement", | ||
| "AzureServiceName": "Azure Resource Manager", | ||
| "URL": "https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/create-private-link-access-portal" | ||
| }, |
There was a problem hiding this comment.
Are you sure the document link of az resourcemanagement is create-private-link-access-portal?
There was a problem hiding this comment.
There was a problem hiding this comment.
Out of curiosity, shouldn't the private-link be just a part of resource management? Shouldn't Azure Resource Manager documentation | Microsoft Docs be a more appropriate doc link for the az resourcemanagement command?
There was a problem hiding this comment.
The Private Link work is a subsection of resource management with several specific constraints. As far as helpfulness to the user, the private link specific documentation would be more useful.
5 participants
Description
This PR enables private link commands to create, update, list, show, and delete resource manager private links and private link associations. Microsoft.Resources is updated to use the latest Python SDK.
Testing Guide
History Notes
[ARM]
az resourcemanagement private-link create: Create Resource management private link[ARM]
az resourcemanagement private-link delete: Delete Resource management private link[ARM]
az resourcemanagement private-link show: Get Resource management private link[ARM]
az resourcemanagement private-link list: List Resource management private link[ARM]
az private-link association create: Create private link association[ARM]
az private-link association delete: Delete private link association[ARM]
az private-link association show: Get private link association[ARM]
az private-link association list: List private link associationThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.