{NetAppFiles} Fix#21954 fix flaky test #21955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
added
the
Collaborator
|
NetAppFiles |
added 2 commits
April 8, 2022 08:00
…y thath since not able to mount volume
jiasli
reviewed
Apr 8, 2022
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_snapshot_commands.py
Outdated
Show resolved
Hide resolved
jiasli
approved these changes
Apr 8, 2022
kairu-ms
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #21954
Test marked as serial-test to prevent teardown being run in parallel to other tests.
Test inverted since we are not able to mount the volume to create the restore file through CLI (Check for error instead of happy path)
Added return to the custom command in question to make sure the operation finishes before the teardown takes place in the test.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.