Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Mar 17, 2022

Description

File names like Dockerfile.ubi8 are not valid file names and cannot be recognized by VS Code, PyCharm or GitHub for syntax highlighting.

GitHub sees it as ubi8 file:

image

These files are renamed to {platform}.dockerfile so that they can be syntax highlighted:

GitHub before/after:

image

image

PyCharm before/after:

image

image

@ghost ghost requested a review from yonzhan March 17, 2022 09:13
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 17, 2022
@ghost ghost assigned jiasli Mar 17, 2022
@ghost ghost added the Packaging label Mar 17, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 17, 2022

Packaging

@yonzhan yonzhan added this to the Mar 2022 (2022-04-06) milestone Mar 17, 2022
@jiasli jiasli changed the title {Packaging} Rename Dockerfiles.* to *.dockerfile {Packaging} Rename Dockerfile.* to *.dockerfile Mar 22, 2022
@jiasli jiasli merged commit 6b99f2f into Azure:dev Mar 22, 2022
@jiasli jiasli deleted the dockerfile branch March 22, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants