Skip to content

{Role} az ad sp create-for-rbac: Add version to the warning when --scopes defaults to subscription #21322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 3 commits into from
Feb 17, 2022
Merged

{Role} az ad sp create-for-rbac: Add version to the warning when --scopes defaults to subscription #21322

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c071ec2
Add version
jiasli Feb 16, 2022
b3a6b35
update
jiasli Feb 17, 2022
0433ac8
Update _help.py
jiasli Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/azure-cli/azure/cli/command_modules/role/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@


By default, this command does not assign any role to the service principal.
You may use --role and --scopes to assign a specific role and narrow the scope to a resource or resource group.
Specify both --role and --scopes to assign a specific role and narrow the scope to a resource or resource group.
You may also use `az role assignment create` to create role assignments for this service principal later.
See [steps to add a role assignment](https://aka.ms/azadsp-more) for more information.
parameters:
Expand All @@ -409,6 +409,7 @@
- name: --scopes
short-summary: >
Space-separated list of scopes the service principal's role assignment applies to.
Starting from Azure CLI 2.35.0, --scopes argument will become required for creating role assignments.
Defaults to the root of the current subscription. e.g., /subscriptions/0b1f6471-1bf0-4dda-aec3-111122223333,
/subscriptions/0b1f6471-1bf0-4dda-aec3-111122223333/resourceGroups/myGroup, or
/subscriptions/0b1f6471-1bf0-4dda-aec3-111122223333/resourceGroups/myGroup/providers/Microsoft.Compute/virtualMachines/myVM
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/role/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@

logger = get_logger(__name__)

SCOPE_WARNING = "In a future release, --scopes argument will become required for creating a role assignment. " \
"Please explicitly specify --scopes."
SCOPE_WARNING = "Starting from Azure CLI 2.35.0, --scopes argument will become required for creating role " \
"assignments. Please explicitly specify --scopes."

# pylint: disable=too-many-lines

Expand Down