[App Service] az webapp create: Provide support --https-only flag
#21286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotasudhakarreddy
requested review from
jsntcy,
panchagnula and
zhoxing-ms
as code owners
Collaborator
|
AppService |
Kotasudhakarreddy
changed the title
az webapp create does not support --https-only flag
Kotasudhakarreddy
changed the title
az webapp create does not support --https-only flagaz webapp create : provide support --https-only flag
Kotasudhakarreddy
changed the title
az webapp create : provide support --https-only flagaz webapp create : provide support --https-only flag
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Kotasudhakarreddy
changed the title
az webapp create : provide support --https-only flagaz webapp create : Provide support --https-only flag
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
StrawnSC
approved these changes
Feb 15, 2022
Contributor
StrawnSC
left a comment
StrawnSC
left a comment
There was a problem hiding this comment.
LGTM. The --https-only feature works for me when I try it
@zhoxing-ms it looks like the CI test failures are unrelated since the failing tests are in the monitor and network command modules
Contributor
zhoxing-ms
changed the title
az webapp create : Provide support --https-only flagaz webapp create : Provide support --https-only flag
zhoxing-ms
changed the title
az webapp create : Provide support --https-only flagaz webapp create: Provide support --https-only flag
zhoxing-ms
approved these changes
Feb 16, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #19415
Description
Due to Azure Policy we need to enable https by default on the webapp (who wouldn't want that?) and not via az webapp update.
Testing Guide
az webapp create -g MyResourceGroup -p MyPlan -n MyUniqueAppName --https-onlyHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change.[Component Name 2]
az command b: Add some customer-facing feature.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.