[Monitor] az monitor log-analytics workspace table: Add new command create, delete and search-job create to support Microsoft/Custom log/Search Results table operations, az monitor log-analytics workspace update: Add a new parameter --data-collection-rule to support update defaultDataCollectionRuleResourceId
#20968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jing-song
changed the title
az monitor log-analytics workspace table: Add new command create and delete to support table operationsaz monitor log-analytics workspace table: Add new command create and delete to support table operations, az monitor log-analytics workspace update: Add a new parameter --data-collection-rule to support update defaultDataCollectionRuleResourceId
Collaborator
|
Monitor |
jsntcy
reviewed
Jan 21, 2022
jsntcy
reviewed
Jan 21, 2022
jsntcy
reviewed
Jan 21, 2022
jsntcy
reviewed
Jan 21, 2022
jsntcy
reviewed
Jan 21, 2022
jsntcy
reviewed
Jan 21, 2022
...e-cli/azure/cli/command_modules/monitor/tests/latest/test_monitor_log_analytics_workspace.py
Show resolved
Hide resolved
Contributor
Author
|
Edge build |
kairu-ms
approved these changes
Jan 27, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Jing-song
changed the title
az monitor log-analytics workspace table: Add new command create and delete to support table operations, az monitor log-analytics workspace update: Add a new parameter --data-collection-rule to support update defaultDataCollectionRuleResourceIdaz monitor log-analytics workspace table: Add new command create, delete and search-job create to support Microsoft/Custom log/Search Results table operations, az monitor log-analytics workspace update: Add a new parameter --data-collection-rule to support update defaultDataCollectionRuleResourceId
jsntcy
reviewed
Feb 17, 2022
src/azure-cli/azure/cli/command_modules/monitor/operations/log_analytics_workspace.py
Show resolved
Hide resolved
Member
|
@PARADISSEEKR Overall LGTM, just a minor suggestion. |
jsntcy
approved these changes
Feb 17, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsntcy
approved these changes
Feb 17, 2022
zhoxing-ms
approved these changes
Feb 17, 2022
Member
|
PR title is so loooong. Better to move to History Notes part in PR description |
evelyn-ys
reviewed
Feb 17, 2022
| 'azure-mgmt-keyvault==9.3.0', | ||
| 'azure-mgmt-kusto~=0.3.0', | ||
| 'azure-mgmt-loganalytics~=12.0.0', | ||
| 'azure-mgmt-loganalytics~=13.0.0b1', |
Member
There was a problem hiding this comment.
If the SDK is beta version, why not support in cli extension?
wangzelin007
approved these changes
Feb 17, 2022
evelyn-ys
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microsot.OperationalInsights: Required CLI changes #20903
close #20903
wait SDK release(done)
Testing Guide
History Notes
[Monitor]
az monitor log-analytics workspace table: Add new commandcreate,deleteandsearch-job createto support Microsoft/Custom log/Search Results table operations,[Monitor]
az monitor log-analytics workspace update: Add a new parameter--data-collection-ruleto support update defaultDataCollectionRuleResourceIdThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.